Gradient on 5K resolution is solid color

[evenbrenden]

Running

hsetroot -add "#FF0000" -add "#0000FF" -gradient 0 -write gradient.jpeg

on a 5120x2160 monitor yields an image of a solid red:

It appears that for a sufficiently large resolution, gradient commands produce a solid of the first color added.

[himdel]

Seeing the same thing, unfortunately this seems to be an imlib2 issue...

        imlib_image_fill_color_range_rectangle(1000, 1000, 4096, 1000, 0);

renders a perfectly valid gradient, but

        imlib_image_fill_color_range_rectangle(1000, 1000, 4097, 1000, 0);

renders only one color.

So, if any dimension is larger than 4096 it won't work :(.

---

Trying to figure out if this is something fixed in newer imlib, or if we need to split this into smaller gradients.

[lindhobe]

The gradient malfunctions are due to an 32-bit integer overflow bug in the _DrawGradient function of imlib2, which was fixed in a recent commit:
https://git.enlightenment.org/old/legacy-imlib2/commit/c30f8528585f86fa0dfe68f391251e23187d662a
This should be included in the next release of imlib2.

And a second commit improves gradient appearance when using an angle that isn't an integer multiple of 90 degrees:
https://git.enlightenment.org/old/legacy-imlib2/commit/1e92ccf562de6b26c9dc4713a6b91b8adf666978