Add Prajal Sharma's GitHub profile information#1120
Add Prajal Sharma's GitHub profile information#1120prajalsharma wants to merge 2 commits intoholdex:mainfrom
Conversation
Added a new entry for Prajal Sharma with GitHub handle and trial issue link. Signed-off-by: DarthPrajal <prajalsharma1120@gmail.com>
Time Submission Status
You can submit time with the command. Example: See available commands to help comply with our Guidelines. |
WalkthroughAppends a new team profile object for Prajal Sharma to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This pull request aims to add a new profile entry for Prajal Sharma to the team profiles JSON file. However, the changes contain critical JSON syntax errors that prevent the file from being valid JSON.
Changes:
- Attempted to add a new profile entry with GitHub handle "prajalsharma", full name "Prajal Sharma", and trial issue link
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
profile-submission.json
Outdated
| "github_trial_issue_link": "https://github.com/holdex/trial/issues/675", | ||
| { |
There was a problem hiding this comment.
The JSON structure is incorrect. Line 896 should end with a closing brace "}" for the "arishtj" object, but instead a comma was added followed by an opening brace on line 897, creating nested objects instead of separate array elements.
The new entry for "prajalsharma" should be a separate object in the array, not nested within the "arishtj" object. Remove the comma from line 896 and close the "arishtj" object properly with "}" on a new line. Then add a comma after that closing brace and start the new "prajalsharma" object on the following line at the same indentation level as the other profile objects.
profile-submission.json
Outdated
| { | ||
| "github_handle": "prajalsharma", | ||
| "full_name": "Prajal Sharma", | ||
| "github_trial_issue_link": "https://github.com/holdex/trial/issues/1112" | ||
| } |
There was a problem hiding this comment.
Inconsistent indentation for the new profile entry. The opening brace on line 897 and the fields on lines 898-900 do not follow the indentation pattern used by other profile objects in the array. All profile objects should start with consistent indentation (using tabs or spaces matching the rest of the file), with their properties indented one level further.
profile-submission.json
Outdated
| "github_trial_issue_link": "https://github.com/holdex/trial/issues/675", | ||
| { | ||
| "github_handle": "prajalsharma", | ||
| "full_name": "Prajal Sharma", | ||
| "github_trial_issue_link": "https://github.com/holdex/trial/issues/1112" | ||
| } | ||
|
|
||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
Missing comma after the closing brace on line 901. Since this is part of an array of profile objects and not the last element (there's still the closing brace for "arishtj" object on line 903), a comma is needed after line 901 to separate array elements properly.
| "github_trial_issue_link": "https://github.com/holdex/trial/issues/675", | |
| { | |
| "github_handle": "prajalsharma", | |
| "full_name": "Prajal Sharma", | |
| "github_trial_issue_link": "https://github.com/holdex/trial/issues/1112" | |
| } | |
| } | |
| ] | |
| } | |
| "github_trial_issue_link": "https://github.com/holdex/trial/issues/675" | |
| }, | |
| { | |
| "github_handle": "prajalsharma", | |
| "full_name": "Prajal Sharma", | |
| "github_trial_issue_link": "https://github.com/holdex/trial/issues/1112" | |
| } | |
| ] | |
| } |
profile-submission.json
Outdated
| "github_trial_issue_link": "https://github.com/holdex/trial/issues/675", | ||
| { | ||
| "github_handle": "prajalsharma", | ||
| "full_name": "Prajal Sharma", | ||
| "github_trial_issue_link": "https://github.com/holdex/trial/issues/1112" | ||
| } | ||
|
|
||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
The closing brace on line 903 appears to be an extra brace that would be left over after fixing the JSON structure. Once the "arishtj" object is properly closed before the new "prajalsharma" entry, this brace will be extraneous and should be removed.
| "github_trial_issue_link": "https://github.com/holdex/trial/issues/675", | |
| { | |
| "github_handle": "prajalsharma", | |
| "full_name": "Prajal Sharma", | |
| "github_trial_issue_link": "https://github.com/holdex/trial/issues/1112" | |
| } | |
| } | |
| ] | |
| } | |
| "github_trial_issue_link": "https://github.com/holdex/trial/issues/675" | |
| }, | |
| { | |
| "github_handle": "prajalsharma", | |
| "full_name": "Prajal Sharma", | |
| "github_trial_issue_link": "https://github.com/holdex/trial/issues/1112" | |
| } | |
| ] | |
| } |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@profile-submission.json`:
- Around line 894-903: The JSON has a malformed object around the entries with
keys "github_handle", "full_name", and "github_trial_issue_link" (arishtj and
prajalsharma): close the first object for "arishtj" before starting the next
object, remove the stray standalone brace/incorrect punctuation, and ensure
objects are either elements of an array or properties of a parent object with
proper commas between them so the structure parses correctly; locate the block
containing "github_handle": "arishtj" and "github_handle": "prajalsharma" and
fix the surrounding braces/commas so each entry is a valid JSON object.
Signed-off-by: DarthPrajal <prajalsharma1120@gmail.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@profile-submission.json`:
- Line 893: The opening brace ("{") shown in the diff is indented with a tab
character while the rest of the JSON uses spaces; replace that tab with the
file's standard spaces (match the existing indentation style, e.g., 2 or 4
spaces) so there are no mixed tabs/spaces, and run the JSON/formatter or linter
to normalize indentation across the file.
| "github_trial_issue_link": "https://github.com/holdex/trial/issues/1038" | ||
| }, | ||
| { | ||
| { |
There was a problem hiding this comment.
Inconsistent indentation — tab+space instead of spaces.
Line 893 uses a tab character for indentation while the rest of the file uses spaces. Normalize to match.
Suggested fix
- {
+ {📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| { | |
| { |
🤖 Prompt for AI Agents
In `@profile-submission.json` at line 893, The opening brace ("{") shown in the
diff is indented with a tab character while the rest of the JSON uses spaces;
replace that tab with the file's standard spaces (match the existing indentation
style, e.g., 2 or 4 spaces) so there are no mixed tabs/spaces, and run the
JSON/formatter or linter to normalize indentation across the file.
zolotokrylin
left a comment
zolotokrylin
left a comment
There was a problem hiding this comment.
- see comments by coderabbit
- the issue is not attached to the PR
- wrong PR title
See our guidelines
|
@holdex pr submit-time 10m |
Added a new entry for Prajal Sharma with GitHub handle and trial issue link.
Summary by CodeRabbit