From 50fbeda9049deabb9b62f1e3c7af1ac2697b1aa0 Mon Sep 17 00:00:00 2001
From: Maxim Zakharov <dp.maxime@gmail.com>
Date: Sat, 21 May 2016 21:39:31 +1000
Subject: [PATCH 1/2] force grep to treat stdin as text file

---
 gitstats | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gitstats b/gitstats
index c71b0e4..bf4d126 100755
--- a/gitstats
+++ b/gitstats
@@ -327,7 +327,7 @@ class GitDataCollector(DataCollector):
 
 		# Collect revision statistics
 		# Outputs "<stamp> <date> <time> <timezone> <author> '<' <mail> '>'"
-		lines = getpipeoutput(['git rev-list --pretty=format:"%%at %%ai %%aN <%%aE>" %s' % getlogrange('HEAD'), 'grep -v ^commit']).split('\n')
+		lines = getpipeoutput(['git rev-list --pretty=format:"%%at %%ai %%aN <%%aE>" %s' % getlogrange('HEAD'), 'grep -av ^commit']).split('\n')
 		for line in lines:
 			parts = line.split(' ', 4)
 			author = ''
@@ -434,7 +434,7 @@ class GitDataCollector(DataCollector):
 			self.commits_by_timezone[timezone] = self.commits_by_timezone.get(timezone, 0) + 1
 
 		# outputs "<stamp> <files>" for each revision
-		revlines = getpipeoutput(['git rev-list --pretty=format:"%%at %%T" %s' % getlogrange('HEAD'), 'grep -v ^commit']).strip().split('\n')
+		revlines = getpipeoutput(['git rev-list --pretty=format:"%%at %%T" %s' % getlogrange('HEAD'), 'grep -av ^commit']).strip().split('\n')
 		lines = []
 		revs_to_read = []
 		time_rev_count = []

From 14919fe10dee40d084117c0d95e28fe02ac2158a Mon Sep 17 00:00:00 2001
From: Maxim Zakharov <dp.maxime@gmail.com>
Date: Sat, 21 May 2016 21:55:22 +1000
Subject: [PATCH 2/2] process wait is not needed as process communicate waits
 until process termination and the last process int the pipeline do not
 terminate until all previous processes int the pipeline terminate; in
 addition process wait may deadlock on big output

---
 gitstats | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/gitstats b/gitstats
index bf4d126..b80a9a2 100755
--- a/gitstats
+++ b/gitstats
@@ -57,13 +57,9 @@ def getpipeoutput(cmds, quiet = False):
 		print '>> ' + ' | '.join(cmds),
 		sys.stdout.flush()
 	p = subprocess.Popen(cmds[0], stdout = subprocess.PIPE, shell = True)
-	processes=[p]
 	for x in cmds[1:]:
 		p = subprocess.Popen(x, stdin = p.stdout, stdout = subprocess.PIPE, shell = True)
-		processes.append(p)
 	output = p.communicate()[0]
-	for p in processes:
-		p.wait()
 	end = time.time()
 	if not quiet:
 		if ON_LINUX and os.isatty(1):