Support Tctl temps in AMD CPUs without Tccd temps

[drunk-moe]

Hello - this is more of a feature request.

Unfortunately, I noticed when checking htop I was not getting the temps from the CPU exposed. Poking around, I realized my laptop only shows Tctl temps. It appears that if a bit isn't set to say Tccd data is valid, hwmon ignores it (relevant code]

Is there any way to add a check for this? I noticed two places in the code that reference k10 so I'm not sure what all would need to be changed, but it looks like this may be the place

Either way, it's nothing urgent. It would be nice to see my CPU temps in htop so I don't have to use something like watch.

Thanks!

[Watrdguy]

Can I work on this?

[Watrdguy]

You can see the temperature by adding it from display option in Setup(F2), it still won't give temperature for each core but show Tctl value for every core.

Unfortunately, I noticed when checking htop I was not getting the temps from the CPU exposed. Poking around, I realized my laptop only shows Tctl temps. It appears that if a bit isn't set to say Tccd data is valid, hwmon ignores it

If temperature for each core is needed(Tccd), different driver than k10temp is needed.

Either way, it's nothing urgent. It would be nice to see my CPU temps in htop so I don't have to use something like watch.

[BenBE]

Can I work on this?

Sure. Go on ahead.

[Watrdguy]

You can see the temperature by adding it from display option in Setup(F2), it still won't give temperature for each core but show Tctl value for every core.

Unfortunately, I noticed when checking htop I was not getting the temps from the CPU exposed. Poking around, I realized my laptop only shows Tctl temps. It appears that if a bit isn't set to say Tccd data is valid, hwmon ignores ithoul

If temperature for each core is needed(Tccd), different driver than k10temp is needed.

Either way, it's nothing urgent. It would be nice to see my CPU temps in htop so I don't have to use something like watch.

This issue should be closed

[drunk-moe]

You can see the temperature by adding it from display option in Setup(F2), it still won't give temperature for each core but show Tctl value for every core.

Unfortunately, I noticed when checking htop I was not getting the temps from the CPU exposed. Poking around, I realized my laptop only shows Tctl temps. It appears that if a bit isn't set to say Tccd data is valid, hwmon ignores ithoul

If temperature for each core is needed(Tccd), different driver than k10temp is needed.

Either way, it's nothing urgent. It would be nice to see my CPU temps in htop so I don't have to use something like watch.

This issue should be closed

Unfortunately, I think there may be a misunderstanding (apologies for not responding sooner, I've been a bit tied up.).

I have 2 computers that use k10temp. One is a desktop that uses a common AMD CPU, the other is my laptop that uses a Ryzen Pro SKU.

Here's my desktop's sensors output:

k10temp-pci-00c3
Adapter: PCI adapter
Tctl:         +34.2°C  
Tccd1:        +34.2°C 

Tccd1 (Thermal Core Complex Die 1) is the temp used by htop (linked in the above code). It is not a per core temp but a temp for one or more Core Complex Dies. This value is discarded by k10temp if a bit-check fails.

My laptop, for example, only returns the Tctl (Thermal Control - used for fans/cooling and what not):

k10temp-pci-00c3
Adapter: PCI adapter
Tctl:         +45.5°C  

Indeed, if I enable CPU temps in htop, I get "N/A" on every column on my laptop while my desktop returns the Tccd1 temp on every core (which is to be expected). I'm reporting that there should maybe be a fallback to grab Tctl temps if Tccd temps are unavailble.

If this is a no fix/there isn't enough bandwidth, I completely understand. I can always just use watch & grep to check the temps. I did want to raise this issue though because it would be nice to have.