Reduce high CPU usage during downloads (#291)

* Reduce CPU usage during downloads

* Clean up comments

Author: DePasqualeOrg

Sources/Hub/Downloader.swift

@@ -262,16 +262,30 @@ final class Downloader: NSObject, Sendable {
 
         var newNumRetries = numRetries
         do {
+            // Batch collect bytes to reduce Data.append() overhead
+            // Use ContiguousArray for better performance (no NSArray bridging overhead)
+            let batchSize = 16384 // 16 kB
+            var byteBatch = ContiguousArray<UInt8>()
+            byteBatch.reserveCapacity(batchSize)
+
             for try await byte in asyncBytes {
-                buffer.append(byte)
+                byteBatch.append(byte)
+
+                // Append batch to main buffer
+                if byteBatch.count >= batchSize {
+                    buffer.append(contentsOf: byteBatch)
+                    byteBatch.removeAll(keepingCapacity: true)
+                }
+
                 // When buffer is full, write to disk
-                if buffer.count == chunkSize {
+                if buffer.count >= chunkSize {
                     if !buffer.isEmpty { // Filter out keep-alive chunks
                         try tempFile.write(contentsOf: buffer)
+                        let bytesWritten = buffer.count
                         buffer.removeAll(keepingCapacity: true)
 
-                        totalDownloadedLocal += chunkSize
-                        await downloadResumeState.incDownloadedSize(chunkSize)
+                        totalDownloadedLocal += bytesWritten
+                        await downloadResumeState.incDownloadedSize(bytesWritten)
                         newNumRetries = 5
                         guard let expectedSize = await downloadResumeState.expectedSize else { continue }
                         let progress = expectedSize != 0 ? Double(totalDownloadedLocal) / Double(expectedSize) : 0
@@ -289,6 +303,11 @@ final class Downloader: NSObject, Sendable {
                 }
             }
 
+            // Flush remaining bytes from batch
+            if !byteBatch.isEmpty {
+                buffer.append(contentsOf: byteBatch)
+            }
+
             if !buffer.isEmpty {
                 try tempFile.write(contentsOf: buffer)
                 totalDownloadedLocal += buffer.count
@@ -445,12 +464,8 @@ actor Broadcaster<E: Sendable> {
 
     func broadcast(state: E) async {
         latestState = state
-        await withTaskGroup(of: Void.self) { group in
-            for continuation in continuations.values {
-                group.addTask {
-                    continuation.yield(state)
-                }
-            }
+        for continuation in continuations.values {
+            continuation.yield(state)
         }
     }
 }