generated from fastai/nbdev_template
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Open
Description
Systematically refactor KTOTrainer to align with modern trainer architecture patterns, improving maintainability, reducing complexity, and adding missing features.
Problem
KTOTrainer currently has complex code with several architectural issues.
Refactoring Plan
1: Foundation & Infrastructure
Establish modern patterns without breaking functionality
- Modernize Model Initialization: Refactor KTO [1/N]: Modernize model initialization #4783
- Use
create_model_from_path()helper - Simplify dtype and device_map handling
- Clean up ref_model initialization
- Use
- Improve Config Validation: Refactor KTO [2/N]: Improve config validation in KTOConfig #4787
2: Dataset Processing Modernization
Adopt standard trainers' clean preprocessing patterns
- Extract
_prepare_datasetmethod: Refactor KTO [3/N]: Extract dataset processing to _prepare_dataset method #4788
3: Reference Model Handling
Simplify ref model management
4: Loss Computation & Forward Pass
Reduce duplication in loss computation
5: Metrics & Logging
Match standard metrics system
6: Evaluation & Generation
Modern evaluation features
7: Documentation
Complete, clear documentation
Phase 8: Advanced Features
Feature parity with standard trainers
Phase 9: Testing
Production ready
Metadata
Metadata
Assignees
Labels
No labels