feature(endpoint.Service)!: Bind multiple ephemeral identities at the same time #1009 #1033
+626
−427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HayimShaul
force-pushed
the
1009-unite-multiple-binds-2
branch
from
312e46b to
5625f77
Compare
Member
mbrandenburger
left a comment
mbrandenburger
left a comment
There was a problem hiding this comment.
Thanks again for addressing my comments.
platform/view/services/storage/driver/sql/postgres/binding_test.go
Outdated
Show resolved
Hide resolved
platform/view/services/storage/driver/sql/sqlite/binding_test.go
Outdated
Show resolved
Hide resolved
HayimShaul
force-pushed
the
1009-unite-multiple-binds-2
branch
from
674d885 to
2cd3a22
Compare
HayimShaul
force-pushed
the
1009-unite-multiple-binds-2
branch
2 times, most recently
from
406634f to
efa9438
Compare
mbrandenburger
requested changes
Nov 5, 2025
Member
mbrandenburger
left a comment
mbrandenburger
left a comment
There was a problem hiding this comment.
Thanks for this PR! It is in a good shape already. See below a few minor comments to address. Thanks again!
platform/view/services/storage/driver/sql/postgres/binding_test.go
Outdated
Show resolved
Hide resolved
platform/view/services/storage/driver/sql/sqlite/binding_test.go
Outdated
Show resolved
Hide resolved
mbrandenburger
requested changes
Nov 6, 2025
platform/view/services/storage/driver/sql/sqlite/binding_test.go
Outdated
Show resolved
Hide resolved
platform/view/services/storage/driver/sql/postgres/binding_test.go
Outdated
Show resolved
Hide resolved
HayimShaul
force-pushed
the
1009-unite-multiple-binds-2
branch
from
a943954 to
67820e0
Compare
AkramBitar
approved these changes
Nov 12, 2025
Signed-off-by: Hayim.Shaul@ibm.com <hayimsha@he4cloud1.sl.cloud9.ibm.com>
mbrandenburger
force-pushed
the
1009-unite-multiple-binds-2
branch
from
4b7c81e to
d6717c0
Compare
mbrandenburger
approved these changes
Nov 18, 2025
Member
mbrandenburger
left a comment
mbrandenburger
left a comment
There was a problem hiding this comment.
Thanks @HayimShaul LGTM
mbrandenburger
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to allow the binding of multiple identities at the same time so to same in the number of DB connections when binding multiple identities. This will be used in the token-sdk.
This PR is linked to FTS's PR hyperledger-labs/fabric-token-sdk#1245
Note
This PR contains a breaking change on the endpoint service API
Bind(ctx context.Context, longTerm view.Identity, ephemeralIDs ...view.Identity) error