[Bug] Hypothes.is not updated after opening new file.

[StructSeeker]

There is an upload button for hypothesis's pdf.js view:

However, when i upload a local file via this button, the hypothes.is sidebar remain the content for original file.

I suppose with this bug fixed, it's possible to use hypothes.is on android device without hosting file on server, as i can use a dummy page and upload the file, i am actually considering developing a PWA out of it, making the mobile use of hypothes.is easier.

Now, after playing around with the code, it seems the problem can be fixed by modifying webViewerFileInputChange in web/viewer.js by adding the following at the end of the function

    function loadHypothesis() {
      PDFViewerApplication.initializedPromise.then(() => {
        const embedScript = document.createElement('script');
        embedScript.src = 'https://hypothes.is/embed.js';
        document.body.appendChild(embedScript);
      });
    }

    function unloadHypothesis() {
      var appLinkEl =
          document.querySelector('link[type="application/annotator+html"]');
      appLinkEl.dispatchEvent(new Event('destroy'));
    };
    
    function reloadHypothesis(){
      unloadHypothesis(); loadHypothesis();
    }
    
    reloadHypothesis()

I don't know it's the correct way, but Do please consider fix this bug!

[robertknight]

That code should work, although this could be handled in a more efficient way if the Hypothesis client monitored for changes in the current file rather than requiring the whole client to be reloaded. We already support this for web pages, but not PDFs.

We are currently having some internal discussions about packaging PDF.js + Hypothesis in a way that is easier for us to share across projects. In that context we'll need to avoid hard-coding the client URL as it varies depending on context.

My suggestions for the moment are:

• Go and and use the code snippet you posted in your own project
• Leave this issue open to track the problem

[StructSeeker]

@robertknight Thank you for! Please Consider publish the supposed hypothes.is+pdf.js package on npm once your change is done.

[StructSeeker]

Is it possible to add a way (e.g. an event) to requrest/notify the client about the webpage change？ link

[robertknight]

Is it possible to add a way (e.g. an event) to requrest/notify the client about the webpage change？

This would need to be implemented as part of Hypothesis's PDF.js integration. We handle document changes in regular (ie. HTML) web pages already. See implementation.