Fix customParseFormat monthIndex calculation for december and "format" month strings #2942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the months/monthsShort locale date is split into standalone and format parts the matchIndex will be 12n + 11 for december, which ends up as 0 if one is added before the modulo, which results in e.g. 0 || 23 == 23, interpreted by dayjs as dec next year, since it's invalid to assume that the original matchIndex is <= 12. Instead do the modulo before adding one and adjust the bounds check. Fixes iamkun#2249
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #2251 to fix #2249. Adjust the bounds check instead of introducing a helper function. Added test cases making use of existing locale data.
Had to use belarussian locale because that's the only one with a
monthsShortwhere the string for december actually differs between format and standalone variants.Fixes #2249
Fixes #2483
Fixes #2511