Skip to content

Commit 56633f7

Browse files
authored
Merge pull request #124 from igerber/trop-remove-jacknife
Remove jackknife variance estimation from TROP
2 parents 06c3cd7 + e93069a commit 56633f7

File tree

6 files changed

+31
-360
lines changed

6 files changed

+31
-360
lines changed

CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

8+
## [Unreleased]
9+
10+
### Removed
11+
- **TROP `variance_method` parameter** — Jackknife variance estimation removed.
12+
Bootstrap (the only method specified in Athey et al. 2025) is now always used.
13+
The `variance_method` field has also been removed from `TROPResults`.
14+
815
## [2.2.0] - 2026-01-27
916

1017
### Added

README.md

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1274,7 +1274,6 @@ TROP(
12741274
max_iter=100, # Max iterations for factor estimation
12751275
tol=1e-6, # Convergence tolerance
12761276
alpha=0.05, # Significance level
1277-
variance_method='bootstrap', # 'bootstrap' or 'jackknife'
12781277
n_bootstrap=200, # Bootstrap replications
12791278
seed=None # Random seed
12801279
)
@@ -1874,8 +1873,7 @@ TROP(
18741873
max_iter=100, # Max iterations for factor estimation
18751874
tol=1e-6, # Convergence tolerance
18761875
alpha=0.05, # Significance level for CIs
1877-
variance_method='bootstrap', # 'bootstrap' or 'jackknife'
1878-
n_bootstrap=200, # Bootstrap/jackknife iterations
1876+
n_bootstrap=200, # Bootstrap replications
18791877
seed=None # Random seed
18801878
)
18811879
```
@@ -1899,7 +1897,7 @@ Note: TROP infers treatment periods from the treatment indicator column. The tre
18991897
| Attribute | Description |
19001898
|-----------|-------------|
19011899
| `att` | Average Treatment effect on the Treated |
1902-
| `se` | Standard error (bootstrap or jackknife) |
1900+
| `se` | Standard error (bootstrap) |
19031901
| `t_stat` | T-statistic |
19041902
| `p_value` | P-value |
19051903
| `conf_int` | Confidence interval |
@@ -1918,7 +1916,6 @@ Note: TROP infers treatment periods from the treatment indicator column. The tre
19181916
| `loocv_score` | LOOCV score for selected parameters |
19191917
| `n_pre_periods` | Number of pre-treatment periods |
19201918
| `n_post_periods` | Number of post-treatment periods |
1921-
| `variance_method` | Variance estimation method |
19221919
| `bootstrap_distribution` | Bootstrap distribution (if bootstrap) |
19231920

19241921
**Methods:**

0 commit comments

Comments
 (0)