From 34c8b24835cde8686b1865ba8a7238968da4cc28 Mon Sep 17 00:00:00 2001 From: Pantani Date: Thu, 5 Feb 2026 00:00:18 -0300 Subject: [PATCH 1/3] fix(evolve): add unhandled errors --- evolve/template/add.go | 18 +++++++----------- evolve/template/migrate.go | 3 +++ 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/evolve/template/add.go b/evolve/template/add.go index 245a47cf..c24a8d27 100644 --- a/evolve/template/add.go +++ b/evolve/template/add.go @@ -59,6 +59,9 @@ func commandsStartModify(appPath, binaryName string, version cosmosver.Version) }`, }, nil }) + if err != nil { + return err + } // add the start command flags content, err = xast.ModifyFunction(content, @@ -94,17 +97,7 @@ func commandsGenesisInitModify(appPath, binaryName string) genny.RunFn { // use ast to modify the function that initializes genesisCmd content, err = xast.ModifyFunction(content, "initRootCmd", - xast.AppendFuncAtLine(` - genesisCmd := genutilcli.InitCmd(basicManager, app.DefaultNodeHome) - evnodeconf.AddFlags(genesisCmd) - genesisCmdRunE := genesisCmd.RunE - genesisCmd.RunE = func(cmd *cobra.Command, args []string) error { - if err := genesisCmdRunE(cmd, args); err != nil { - return err - } - return abciserver.InitRunE(cmd, args) - } - `, + xast.AppendFuncAtLine("\n\t\tgenesisCmd := genutilcli.InitCmd(basicManager, app.DefaultNodeHome)\n\t\tevnodeconf.AddFlags(genesisCmd)\n\t\tgenesisCmdRunE := genesisCmd.RunE\n\t\tgenesisCmd.RunE = func(cmd *cobra.Command, args []string) error {\n\t\t\tif err := genesisCmdRunE(cmd, args); err != nil {\n\t\t\t\treturn err\n\t\t\t}\n\t\t\treturn abciserver.InitRunE(cmd, args)\n\t\t}\n\t\t", 0), ) if err != nil { @@ -119,6 +112,9 @@ func commandsGenesisInitModify(appPath, binaryName string) genny.RunFn { return args, nil }) + if err != nil { + return err + } return r.File(genny.NewFileS(cmdPath, content)) } diff --git a/evolve/template/migrate.go b/evolve/template/migrate.go index 559acd35..879e3b81 100644 --- a/evolve/template/migrate.go +++ b/evolve/template/migrate.go @@ -34,6 +34,9 @@ func commandsMigrateModify(appPath, binaryName string) genny.RunFn { return args, nil }) + if err != nil { + return err + } return r.File(genny.NewFileS(cmdPath, content)) } From 8103ce8e0b9a86640adb7ba3c0dcc3993da146b5 Mon Sep 17 00:00:00 2001 From: Pantani Date: Thu, 5 Feb 2026 00:01:12 -0300 Subject: [PATCH 2/3] rollback ident --- evolve/template/add.go | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/evolve/template/add.go b/evolve/template/add.go index c24a8d27..6865e2af 100644 --- a/evolve/template/add.go +++ b/evolve/template/add.go @@ -97,7 +97,17 @@ func commandsGenesisInitModify(appPath, binaryName string) genny.RunFn { // use ast to modify the function that initializes genesisCmd content, err = xast.ModifyFunction(content, "initRootCmd", - xast.AppendFuncAtLine("\n\t\tgenesisCmd := genutilcli.InitCmd(basicManager, app.DefaultNodeHome)\n\t\tevnodeconf.AddFlags(genesisCmd)\n\t\tgenesisCmdRunE := genesisCmd.RunE\n\t\tgenesisCmd.RunE = func(cmd *cobra.Command, args []string) error {\n\t\t\tif err := genesisCmdRunE(cmd, args); err != nil {\n\t\t\t\treturn err\n\t\t\t}\n\t\t\treturn abciserver.InitRunE(cmd, args)\n\t\t}\n\t\t", + xast.AppendFuncAtLine(` + genesisCmd := genutilcli.InitCmd(basicManager, app.DefaultNodeHome) + evnodeconf.AddFlags(genesisCmd) + genesisCmdRunE := genesisCmd.RunE + genesisCmd.RunE = func(cmd *cobra.Command, args []string) error { + if err := genesisCmdRunE(cmd, args); err != nil { + return err + } + return abciserver.InitRunE(cmd, args) + } + `, 0), ) if err != nil { From f72915838791055963633a20273513edb7b92ce2 Mon Sep 17 00:00:00 2001 From: Pantani Date: Thu, 5 Feb 2026 23:10:37 -0300 Subject: [PATCH 3/3] fix os.WriteFile perm --- evolve/cmd/init.go | 2 +- evolve/cmd/init_test.go | 2 +- evolve/template/add.go | 3 +++ 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/evolve/cmd/init.go b/evolve/cmd/init.go index 88631705..c11d25ba 100644 --- a/evolve/cmd/init.go +++ b/evolve/cmd/init.go @@ -234,7 +234,7 @@ func prependFieldToGenesis(genesisPath, fieldName, fieldValue string) error { buf.Write(data[insertPos:]) // Write back to file - if err := os.WriteFile(genesisPath, buf.Bytes(), 0644); err != nil { + if err := os.WriteFile(genesisPath, buf.Bytes(), 0o644); err != nil { return fmt.Errorf("failed to write genesis file: %w", err) } diff --git a/evolve/cmd/init_test.go b/evolve/cmd/init_test.go index 24c21ee5..97bf9e4b 100644 --- a/evolve/cmd/init_test.go +++ b/evolve/cmd/init_test.go @@ -81,7 +81,7 @@ func TestPrependFieldToGenesis(t *testing.T) { tmpDir := t.TempDir() genesisPath := filepath.Join(tmpDir, "genesis.json") - err := os.WriteFile(genesisPath, []byte(tt.input), 0644) + err := os.WriteFile(genesisPath, []byte(tt.input), 0o644) assert.NilError(t, err) err = prependFieldToGenesis(genesisPath, tt.fieldName, tt.fieldValue) diff --git a/evolve/template/add.go b/evolve/template/add.go index 6865e2af..2a28af4d 100644 --- a/evolve/template/add.go +++ b/evolve/template/add.go @@ -157,6 +157,9 @@ func commandsForceInclusionModify(appPath, binaryName string) genny.RunFn { return args, nil }) + if err != nil { + return err + } return r.File(genny.NewFileS(cmdPath, content)) }