-
-
Notifications
You must be signed in to change notification settings - Fork 206
feat: graphlet_basis() returns a list of vertices in the "cliques" component. Replace .Call(Rx_...) with _impl functions for autogenerated entrypoints
#2472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.Call(Rx_...) with _impl functions for autogenerated entrypoints
|
Needs to remove all now unused |
|
@copilot: Merge |
Done in ddbb826. Removed 38 unused
Done. Merged main, reset to main, then reapplied changes as individual commits: |
ddbb826 to
1e2367c
Compare
.Call(Rx_...) with _impl functions for autogenerated entrypoints.Call(Rx_...) with _impl functions for autogenerated entrypoints
6f4428b to
5487c69
Compare
.Call(Rx_...) with _impl functions for autogenerated entrypointsgraphlet_basis() returns a list of vertices in the "cliques" component. Replace .Call(Rx_...) with _impl functions for autogenerated entrypoints
Replace
.Call(Rx_...)with_implfunctions for autogenerated entrypointsThis PR replaces manual
Rx_entrypoint implementations with calls to autogenerated_implfunctions, eliminating code duplication.Progress
Summary
This PR completes the replacement of 38
Rx_entrypoints with their autogenerated_implequivalents:Functions replaced:
add_vertices,delete_edges,delete_vertices,edges,incident,ecount,is_directedlargest_ivs,max_ivs,ivs_sizemincut,mincut_value,vertex_connectivity,edge_connectivity,adhesion,cohesionconstraint,coreness,topo_sort,cocitation,bibcouplingrewire,famous, MST algorithms, graphlets,running_mean,cohesive_blocksRemoved from src/rinterface_extra.c:
All 38 now-unused
Rx_function implementations have been removed, reducing code duplication.Not replaced:
Functions with incompatible signatures remain (e.g.,
maximal_cliques_countwith subset,girthwith circle parameter, union/intersection with list support).Original prompt
.Call(Rx_...)with calling the corresponding_impl#2470💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.