fix(is-overlap): modify policy same date overlap (#8)

* fix(is-overlap): modify policy same date overlap

* fix(is-overlap): add test case

* fix(is-overlap): modify date comparative

* fix(is-overlap): modify conditional statements

Author: imwh0im

src/index.ts

@@ -40,11 +40,7 @@ class DayjsRange {
       return false;
     }
 
-    return (
-      (this.startDate >= other.startDate && this.startDate <= other.endDate) ||
-      (this.endDate >= other.startDate && this.endDate <= other.endDate) ||
-      (this.startDate <= other.startDate && this.endDate >= other.endDate)
-    );
+    return this.startDate < other.endDate && this.endDate > other.startDate;
   }
 
   /**

test/range.test.ts

@@ -43,30 +43,57 @@ it('range isOverlap', () => {
   const otherDate2 = '2021-07-19 00:00:00';
 
   expect(
-    dayjsRange(startDate, endDate).isOverlap(dayjsRange(startDate, endDate)),
+    dayjsRange(startDate, otherDate).isOverlap(dayjsRange(endDate, otherDate2)),
   ).toBe(true);
   expect(
-    dayjsRange(endDate, startDate).isOverlap(dayjsRange(startDate, endDate)),
+    dayjsRange(endDate, otherDate2).isOverlap(dayjsRange(startDate, otherDate)),
   ).toBe(true);
   expect(
-    dayjsRange(startDate, endDate).isOverlap(dayjsRange(endDate, otherDate)),
+    dayjsRange(startDate, endDate).isOverlap(dayjsRange(startDate, otherDate)),
   ).toBe(true);
   expect(
-    dayjsRange(startDate, endDate).isOverlap(dayjsRange(otherDate, otherDate2)),
-  ).toBe(false);
-  expect(
-    dayjsRange(startDate, otherDate).isOverlap(dayjsRange(endDate, otherDate2)),
+    dayjsRange(startDate, otherDate).isOverlap(dayjsRange(startDate, endDate)),
   ).toBe(true);
   expect(
     dayjsRange(startDate, otherDate2).isOverlap(dayjsRange(endDate, otherDate)),
   ).toBe(true);
   expect(
     dayjsRange(endDate, otherDate).isOverlap(dayjsRange(startDate, otherDate2)),
   ).toBe(true);
+  expect(
+    dayjsRange(startDate, endDate).isOverlap(dayjsRange(startDate, endDate)),
+  ).toBe(true);
+  expect(
+    dayjsRange(startDate, endDate).isOverlap(dayjsRange(otherDate, otherDate2)),
+  ).toBe(false);
+  expect(
+    dayjsRange(otherDate, otherDate2).isOverlap(dayjsRange(startDate, endDate)),
+  ).toBe(false);
+  expect(
+    dayjsRange(startDate, endDate).isOverlap(dayjsRange(endDate, otherDate)),
+  ).toBe(false);
+  expect(
+    dayjsRange(endDate, otherDate).isOverlap(dayjsRange(startDate, endDate)),
+  ).toBe(false);
+  expect(
+    dayjsRange(startDate, startDate).isOverlap(dayjsRange(startDate, endDate)),
+  ).toBe(false);
+  expect(
+    dayjsRange(startDate, endDate).isOverlap(dayjsRange(startDate, startDate)),
+  ).toBe(false);
+  expect(
+    dayjsRange(endDate, endDate).isOverlap(dayjsRange(startDate, endDate)),
+  ).toBe(false);
+  expect(
+    dayjsRange(startDate, endDate).isOverlap(dayjsRange(endDate, endDate)),
+  ).toBe(false);
   expect(dayjsRange(endDate, otherDate).isOverlap()).toBe(false);
   expect(
     dayjsRange(startDate, endDate).isOverlap(dayjsRange(startDate, null)),
   ).toBe(false);
+  expect(
+    dayjsRange(startDate, endDate).isOverlap(dayjsRange(endDate, endDate)),
+  ).toBe(false);
 });
 
 it('range get date', () => {