Allow boundaries on interior faces #285
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inducer
reviewed
Nov 29, 2021
|
|
||
| is_untagged = ~np.any(belongs_to_bdry, axis=0) | ||
| if np.any(is_untagged): | ||
| belongs_to_bdry = np.full( |
Owner
There was a problem hiding this comment.
The tagged interfaces should also be removed from the "normal" facial adjacency, to avoid accidentally computing fluxes across these boundary interfaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@inducer I'm guessing you probably won't need this for the multi-domain wave demo, but just in case.