fix: remove the staking portfolio persistence modal (#1572)

greatertomi · web-flow · commit fef43f5d0571 · 2024-12-10T12:50:40.000+01:00
* feat: remove the staking portfolio persistence modal

* test(extension): remove outdated step
diff --git a/apps/browser-extension-wallet/src/features/delegation/components/MultiDelegationStakingPopup.tsx b/apps/browser-extension-wallet/src/features/delegation/components/MultiDelegationStakingPopup.tsx
@@ -22,7 +22,6 @@ import { useWalletActivities } from '@hooks/useWalletActivities';
 import {
   MULTIDELEGATION_DAPP_COMPATIBILITY_LS_KEY,
   MULTIDELEGATION_FIRST_VISIT_LS_KEY,
-  MULTIDELEGATION_FIRST_VISIT_SINCE_PORTFOLIO_PERSISTENCE_LS_KEY,
   STAKING_BROWSER_PREFERENCES_LS_KEY
 } from '@utils/constants';
 import { withSignTxConfirmation } from '@lib/wallet-api-ui';
@@ -104,10 +103,6 @@ export const MultiDelegationStakingPopup = (): JSX.Element => {
   );
   const [multidelegationDAppCompatibility, { updateLocalStorage: setMultidelegationDAppCompatibility }] =
     useLocalStorage(MULTIDELEGATION_DAPP_COMPATIBILITY_LS_KEY, true);
-  const [
-    multidelegationFirstVisitSincePortfolioPersistence,
-    { updateLocalStorage: setMultidelegationFirstVisitSincePortfolioPersistence }
-  ] = useLocalStorage(MULTIDELEGATION_FIRST_VISIT_SINCE_PORTFOLIO_PERSISTENCE_LS_KEY, true);
 
   const [stakingBrowserPreferencesPersistence, { updateLocalStorage: setStakingBrowserPreferencesPersistence }] =
     useLocalStorage(STAKING_BROWSER_PREFERENCES_LS_KEY, DEFAULT_STAKING_BROWSER_PREFERENCES);
@@ -127,14 +122,11 @@ export const MultiDelegationStakingPopup = (): JSX.Element => {
         stakingBrowserPreferencesPersistence,
         setStakingBrowserPreferencesPersistence,
         multidelegationFirstVisit,
-        triggerMultidelegationFirstVisit: () => setMultidelegationFirstVisit(false),
-        multidelegationDAppCompatibility,
-        triggerMultidelegationDAppCompatibility: () => setMultidelegationDAppCompatibility(false),
-        multidelegationFirstVisitSincePortfolioPersistence,
-        triggerMultidelegationFirstVisitSincePortfolioPersistence: () => {
+        triggerMultidelegationFirstVisit: () => {
           setMultidelegationFirstVisit(false);
-          setMultidelegationFirstVisitSincePortfolioPersistence(false);
         },
+        multidelegationDAppCompatibility,
+        triggerMultidelegationDAppCompatibility: () => setMultidelegationDAppCompatibility(false),
         expandStakingView: (urlSearchParams?: string) =>
           handleOpenBrowser({ section: BrowserViewSections.STAKING, urlSearchParams }),
         balancesBalance: balance,
diff --git a/apps/browser-extension-wallet/src/hooks/__tests__/useWalletManager.test.tsx b/apps/browser-extension-wallet/src/hooks/__tests__/useWalletManager.test.tsx
@@ -580,8 +580,7 @@ describe('Testing useWalletManager hook', () => {
           'hideBalance',
           'isForgotPasswordFlow',
           'multidelegationFirstVisit',
-          'isMultiDelegationDAppCompatibilityModalVisible',
-          'multidelegationFirstVisitSincePortfolioPersistence'
+          'isMultiDelegationDAppCompatibilityModalVisible'
         ]
       });
       expect(clearBackgroundStorage).toBeCalledWith({
diff --git a/apps/browser-extension-wallet/src/hooks/useWalletManager.ts b/apps/browser-extension-wallet/src/hooks/useWalletManager.ts
@@ -698,8 +698,7 @@ export const useWalletManager = (): UseWalletManager => {
         'hideBalance',
         'isForgotPasswordFlow',
         'multidelegationFirstVisit',
-        'isMultiDelegationDAppCompatibilityModalVisible',
-        'multidelegationFirstVisitSincePortfolioPersistence'
+        'isMultiDelegationDAppCompatibilityModalVisible'
       ];
 
       if (isForgotPasswordFlow) {
diff --git a/apps/browser-extension-wallet/src/types/local-storage.ts b/apps/browser-extension-wallet/src/types/local-storage.ts
@@ -59,7 +59,6 @@ export interface ILocalStorage {
   isForgotPasswordFlow?: boolean;
   multidelegationFirstVisit?: boolean;
   isMultiDelegationDAppCompatibilityModalVisible?: boolean;
-  multidelegationFirstVisitSincePortfolioPersistence?: boolean;
   unconfirmedTransactions: UnconfirmedTransaction[];
   stakingBrowserPreferences: StakingBrowserPreferences;
   showPinExtension?: boolean;
diff --git a/apps/browser-extension-wallet/src/utils/constants.ts b/apps/browser-extension-wallet/src/utils/constants.ts
@@ -16,8 +16,6 @@ export const cardanoCoin: Wallet.CoinId = {
   symbol: CARDANO_COIN_SYMBOL[Wallet.Cardano.NetworkId.Mainnet]
 };
 
-export const EPOCH_DURATION_DAYS = 5;
-
 export const MIN_COIN_TO_SEND = 1;
 
 export const COLLATERAL_ADA_AMOUNT = 5;
@@ -114,8 +112,6 @@ export const SEND_NFT_DEFAULT_AMOUNT = '1';
 
 export const COINGECKO_URL = 'https://www.coingecko.com';
 
-export const MULTIDELEGATION_FIRST_VISIT_SINCE_PORTFOLIO_PERSISTENCE_LS_KEY =
-  'multidelegationFirstVisitSincePortfolioPersistence';
 export const MULTIDELEGATION_FIRST_VISIT_LS_KEY = 'multidelegationFirstVisit';
 export const MULTIDELEGATION_DAPP_COMPATIBILITY_LS_KEY = 'isMultiDelegationDAppCompatibilityModalVisible';
 export const STAKING_BROWSER_PREFERENCES_LS_KEY = 'stakingBrowserPreferences';
diff --git a/apps/browser-extension-wallet/src/views/browser-view/features/staking/components/StakingContainer.tsx b/apps/browser-extension-wallet/src/views/browser-view/features/staking/components/StakingContainer.tsx
@@ -15,7 +15,6 @@ import { useBalances, useCustomSubmitApi, useFetchCoinPrice, useLocalStorage, us
 import {
   MULTIDELEGATION_DAPP_COMPATIBILITY_LS_KEY,
   MULTIDELEGATION_FIRST_VISIT_LS_KEY,
-  MULTIDELEGATION_FIRST_VISIT_SINCE_PORTFOLIO_PERSISTENCE_LS_KEY,
   STAKING_BROWSER_PREFERENCES_LS_KEY
 } from '@utils/constants';
 import { useDelegationStore } from '@src/features/delegation/stores';
@@ -35,10 +34,6 @@ export const StakingContainer = (): React.ReactElement => {
   );
   const [multidelegationDAppCompatibility, { updateLocalStorage: setMultidelegationDAppCompatibility }] =
     useLocalStorage(MULTIDELEGATION_DAPP_COMPATIBILITY_LS_KEY, true);
-  const [
-    multidelegationFirstVisitSincePortfolioPersistence,
-    { updateLocalStorage: setMultidelegationFirstVisitSincePortfolioPersistence }
-  ] = useLocalStorage(MULTIDELEGATION_FIRST_VISIT_SINCE_PORTFOLIO_PERSISTENCE_LS_KEY, true);
   const sendAnalytics = useCallback(() => {
     // TODO implement analytics for the new flow
     const an = {
@@ -142,11 +137,6 @@ export const StakingContainer = (): React.ReactElement => {
           triggerMultidelegationFirstVisit: () => setMultidelegationFirstVisit(false),
           multidelegationDAppCompatibility,
           triggerMultidelegationDAppCompatibility: () => setMultidelegationDAppCompatibility(false),
-          multidelegationFirstVisitSincePortfolioPersistence,
-          triggerMultidelegationFirstVisitSincePortfolioPersistence: () => {
-            setMultidelegationFirstVisit(false);
-            setMultidelegationFirstVisitSincePortfolioPersistence(false);
-          },
           walletAddress,
           walletName,
           currentChain,
diff --git a/packages/e2e-tests/src/features/MultidelegationDelegatedFundsMultiplePoolsPopup.feature b/packages/e2e-tests/src/features/MultidelegationDelegatedFundsMultiplePoolsPopup.feature
@@ -6,14 +6,12 @@ Feature: Staking Page - Delegated funds - Multiple pools - Popup View
 
   @LW-8330
   Scenario: Popup View - Delegation card displays correct data
-    And I disable showing Multidelegation persistence banner
     When I navigate to Staking popup page
     Then I see Delegation title displayed for multidelegation
     And I see Delegation card displaying correct data
 
   @LW-8338
   Scenario: Popup View - Delegated pools cards are present
-    And I disable showing Multidelegation persistence banner
     When I navigate to Staking popup page
     And I see Delegation pool cards are displayed
 
diff --git a/packages/e2e-tests/src/features/MultidelegationDelegatedFundsSinglePoolPopup.feature b/packages/e2e-tests/src/features/MultidelegationDelegatedFundsSinglePoolPopup.feature
@@ -6,14 +6,12 @@ Feature: Staking Page - Delegated funds - Single pool - Popup View
 
   @LW-8330
   Scenario: Popup View - Delegation card displays correct data
-    And I disable showing Multidelegation persistence banner
     When I navigate to Staking popup page
     Then I see Delegation title displayed for multidelegation
     And I see Delegation card displaying correct data
 
   @LW-8338
   Scenario: Popup View - Delegated pools cards are present
-    And I disable showing Multidelegation persistence banner
     When I navigate to Staking popup page
     And I see Delegation pool cards are displayed
 
diff --git a/packages/e2e-tests/src/features/NetworkSwitchingExtended.feature b/packages/e2e-tests/src/features/NetworkSwitchingExtended.feature
@@ -4,7 +4,6 @@ Feature: LW: Network Switching - extended view
   Background:
     Given Wallet is synced
     And I disable showing Multidelegation beta banner
-    And I disable showing Multidelegation persistence banner
 
   @LW-3226
   Scenario Outline: Extended View - Currency symbol is correct when on different network - <network> <ticker>
diff --git a/packages/e2e-tests/src/fixture/localStorageInitializer.ts b/packages/e2e-tests/src/fixture/localStorageInitializer.ts
@@ -36,10 +36,6 @@ class LocalStorageInitializer {
     await localStorageManager.setItem('multidelegationFirstVisit', 'false');
   };
 
-  disableShowingMultidelegationPersistenceBanner = async () => {
-    await localStorageManager.setItem('multidelegationFirstVisitSincePortfolioPersistence', 'false');
-  };
-
   enableShowingAnalyticsBanner = async () => {
     await localStorageManager.setItem('analyticsStatus', '');
   };
diff --git a/packages/e2e-tests/src/hooks/beforeTagHooks.ts b/packages/e2e-tests/src/hooks/beforeTagHooks.ts
@@ -44,7 +44,6 @@ Before(
   async () => {
     await extendedViewRepositoryWalletInitialization([TestWalletName.TestAutomationWallet]);
     await localStorageInitializer.disableShowingMultidelegationBetaBanner();
-    await localStorageInitializer.disableShowingMultidelegationPersistenceBanner();
   }
 );
 
@@ -55,7 +54,6 @@ Before(
   async () => {
     await popupViewRepositoryWalletInitialization([TestWalletName.TestAutomationWallet]);
     await localStorageInitializer.disableShowingMultidelegationBetaBanner();
-    await localStorageInitializer.disableShowingMultidelegationPersistenceBanner();
   }
 );
 
@@ -122,7 +120,6 @@ Before(
 Before({ tags: '@Staking-DelegatedFunds-Popup or @NetworkSwitching-popup' }, async () => {
   await popupViewRepositoryWalletInitialization([TestWalletName.TAWalletDelegatedFunds]);
   await localStorageInitializer.disableShowingMultidelegationBetaBanner();
-  await localStorageInitializer.disableShowingMultidelegationPersistenceBanner();
 });
 
 Before(
@@ -248,7 +245,6 @@ Before(
   async () => {
     await extendedViewRepositoryWalletInitialization([TestWalletName.MultiAccActive1]);
     await localStorageInitializer.disableShowingMultidelegationBetaBanner();
-    await localStorageInitializer.disableShowingMultidelegationPersistenceBanner();
   }
 );
 
@@ -259,7 +255,6 @@ Before(
   async () => {
     await popupViewRepositoryWalletInitialization([TestWalletName.MultiAccActive1]);
     await localStorageInitializer.disableShowingMultidelegationBetaBanner();
-    await localStorageInitializer.disableShowingMultidelegationPersistenceBanner();
   }
 );
 
@@ -268,7 +263,6 @@ Before(
   async () => {
     await extendedViewRepositoryWalletInitialization([TestWalletName.AddNewWallet]);
     await localStorageInitializer.disableShowingMultidelegationBetaBanner();
-    await localStorageInitializer.disableShowingMultidelegationPersistenceBanner();
     await localStorageInitializer.initializeShowMultiAddressDiscoveryModal(false);
     await localStorageInitializer.disableShowPinExtension();
   }
diff --git a/packages/e2e-tests/src/steps/commonSteps.ts b/packages/e2e-tests/src/steps/commonSteps.ts
@@ -332,10 +332,6 @@ Given(/^I disable showing Multidelegation beta banner$/, async () => {
   await localStorageInitializer.disableShowingMultidelegationBetaBanner();
 });
 
-Given(/^I disable showing Multidelegation persistence banner$/, async () => {
-  await localStorageInitializer.disableShowingMultidelegationPersistenceBanner();
-});
-
 Given(/^I disable showing Multidelegation DApps issue modal$/, async () => {
   await localStorageInitializer.disableShowingMultidelegationDAppsIssueModal();
 });
diff --git a/packages/e2e-tests/src/steps/multidelegationSteps.ts b/packages/e2e-tests/src/steps/multidelegationSteps.ts
@@ -345,7 +345,6 @@ Given(/^I am on Start Staking page in (extended|popup) mode$/, async (mode: 'ext
   await TokensPage.waitUntilCardanoTokenLoaded();
   await TokensPage.saveTokenBalance('Cardano');
   await localStorageInitializer.disableShowingMultidelegationBetaBanner();
-  await localStorageInitializer.disableShowingMultidelegationPersistenceBanner();
   await mainMenuPageObject.navigateToSection('Staking', mode);
   const cardanoBalance = String(await TokensPage.loadTokenBalance('Cardano'));
   await StartStakingPageAssert.assertSeeStartStakingPage(cardanoBalance, mode);
diff --git a/packages/staking/.storybook/StakingStorybookProvider.tsx b/packages/staking/.storybook/StakingStorybookProvider.tsx
@@ -45,8 +45,6 @@ const outsideHandlesMocks: OutsideHandlesContextValue = {
   triggerMultidelegationFirstVisit: undefined,
   multidelegationDAppCompatibility: undefined,
   triggerMultidelegationDAppCompatibility: undefined,
-  multidelegationFirstVisitSincePortfolioPersistence: undefined,
-  triggerMultidelegationFirstVisitSincePortfolioPersistence: undefined,
   walletAddress: undefined,
   walletName: undefined,
   currentChain: undefined,
diff --git a/packages/staking/src/features/modals/PortfolioPersistenceModal.tsx b/packages/staking/src/features/modals/PortfolioPersistenceModal.tsx
diff --git a/packages/staking/src/features/modals/index.ts b/packages/staking/src/features/modals/index.ts
@@ -1,4 +1,3 @@
 export { ChangingPreferencesModal } from './ChangingPreferencesModal';
 export { MultidelegationBetaModal } from './MultidelegationBetaModal';
 export { PoolsManagementModal, PoolsManagementModalType } from './PoolsManagementModal';
-export { PortfolioPersistenceModal } from './PortfolioPersistenceModal';
diff --git a/packages/staking/src/features/outside-handles-provider/types.ts b/packages/staking/src/features/outside-handles-provider/types.ts
@@ -97,8 +97,6 @@ export type OutsideHandlesContextValue = {
   triggerMultidelegationFirstVisit: () => void;
   multidelegationDAppCompatibility: boolean;
   triggerMultidelegationDAppCompatibility: () => void;
-  multidelegationFirstVisitSincePortfolioPersistence: boolean;
-  triggerMultidelegationFirstVisitSincePortfolioPersistence: () => void;
   walletAddress: string;
   walletName: string;
   currentChain: Wallet.Cardano.ChainId;
diff --git a/packages/staking/src/features/staking/OneTimeModals.tsx b/packages/staking/src/features/staking/OneTimeModals.tsx
@@ -1,8 +1,7 @@
 import { MultidelegationDAppCompatibilityModal } from 'features/modals/MultidelegationDAppCompatibilityModal';
 import { useDelegationPortfolioStore } from 'features/store';
-import { isPortfolioSavedOnChain } from 'features/store/delegationPortfolioStore/isPortfolioSavedOnChain';
 import { useEffect } from 'react';
-import { MultidelegationBetaModal, PortfolioPersistenceModal } from '../modals';
+import { MultidelegationBetaModal } from '../modals';
 import { useOutsideHandles } from '../outside-handles-provider';
 
 type OneTimeModalManagerProps = { popupView?: boolean };
@@ -13,14 +12,11 @@ export const OneTimeModals = ({ popupView }: OneTimeModalManagerProps) => {
     triggerMultidelegationFirstVisit,
     multidelegationDAppCompatibility,
     triggerMultidelegationDAppCompatibility,
-    multidelegationFirstVisitSincePortfolioPersistence,
-    triggerMultidelegationFirstVisitSincePortfolioPersistence,
   } = useOutsideHandles();
   const { currentPortfolio } = useDelegationPortfolioStore((store) => ({
     currentPortfolio: store.currentPortfolio,
   }));
   const userAlreadyMultidelegated = currentPortfolio.length > 1;
-  const portfolioSavedOnChain = isPortfolioSavedOnChain(currentPortfolio);
 
   // the useEffects below prevent the modals from appearing to the user in the future e.g. after undelegating the portfolio
   useEffect(() => {
@@ -29,16 +25,6 @@ export const OneTimeModals = ({ popupView }: OneTimeModalManagerProps) => {
     }
   }, [userAlreadyMultidelegated, multidelegationFirstVisit, triggerMultidelegationFirstVisit]);
 
-  useEffect(() => {
-    if (multidelegationFirstVisitSincePortfolioPersistence && portfolioSavedOnChain) {
-      triggerMultidelegationFirstVisitSincePortfolioPersistence();
-    }
-  }, [
-    multidelegationFirstVisitSincePortfolioPersistence,
-    triggerMultidelegationFirstVisitSincePortfolioPersistence,
-    portfolioSavedOnChain,
-  ]);
-
   if (!userAlreadyMultidelegated) {
     return (
       <MultidelegationBetaModal
@@ -59,15 +45,5 @@ export const OneTimeModals = ({ popupView }: OneTimeModalManagerProps) => {
     );
   }
 
-  if (!portfolioSavedOnChain) {
-    return (
-      <PortfolioPersistenceModal
-        visible={multidelegationFirstVisitSincePortfolioPersistence}
-        onConfirm={triggerMultidelegationFirstVisitSincePortfolioPersistence}
-        popupView={popupView}
-      />
-    );
-  }
-
   return null;
 };
diff --git a/packages/translation/src/lib/translations/staking/en.json b/packages/translation/src/lib/translations/staking/en.json
@@ -146,8 +146,6 @@
   "modals.beta.button": "Got it",
   "modals.beta.description": "This feature allows you to stake to up to {{maxPools}} pools. This is still in beta version, so some functionality might not be available. Read more about multi-delegation in our <Link>dedicated blog.</Link>",
   "modals.beta.pill": "Beta",
-  "modals.beta.portfolioPersistence.description": "Lace now supports on-chain portfolio persistence! This feature helps protect portfolios from significant drift and ensures cross-device syncing. If you've previously submitted a delegation, please resubmit your current (or a new) delegation to enable on-chain portfolio persistence.",
-  "modals.beta.portfolioPersistence.title": "Multi-delegation: Portfolio Persistence",
   "modals.beta.title": "Multi-delegation",
   "modals.changingPreferences.buttons.cancel": "Cancel",
   "modals.changingPreferences.buttons.confirm": "Fine by me",
