Skip to content

[Bug]: Build of media-driver 25.4.0 fails with -Werror=dangling-pointer= #1974

@heitbaum

Description

@heitbaum

pParam->Unorm.pIndirectState = &indirectState;

[84/1837] Building CXX object media_driver/CMakeFiles/iHD_drv_video_COMMON.dir/agnostic/gen8/hw/mhw_state_heap_g8.c.o
FAILED: [code=1] media_driver/CMakeFiles/iHD_drv_video_COMMON.dir/agnostic/gen8/hw/mhw_state_heap_g8.c.o 
/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/toolchain/bin/x86_64-libreelec-linux-gnu-g++ -DCLASS_TRACE=0 -DENABLE_KERNELS -DIGFX_ARL_SUPPORTED -DIGFX_DG2_SUPPORTED -DIGFX_GEN11_ICLLP_SUPPORTED -DIGFX_GEN11_JSL_SUPPORTED -DIGFX_GEN11_SUPPORTED -DIGFX_GEN12_ADLN_SUPPORTED -DIGFX_GEN12_ADLP_SUPPORTED -DIGFX_GEN12_ADLS_SUPPORTED -DIGFX_GEN12_DG1_SUPPORTED -DIGFX_GEN12_RKL_SUPPORTED -DIGFX_GEN12_SUPPORTED -DIGFX_GEN12_TGLLP_SUPPORTED -DIGFX_GEN8_BDW_SUPPORTED -DIGFX_GEN8_SUPPORTED -DIGFX_GEN9_BXT_SUPPORTED -DIGFX_GEN9_CFL_SUPPORTED -DIGFX_GEN9_CML_SUPPORTED -DIGFX_GEN9_CMPV_SUPPORTED -DIGFX_GEN9_GLK_SUPPORTED -DIGFX_GEN9_KBL_SUPPORTED -DIGFX_GEN9_SKL_SUPPORTED -DIGFX_GEN9_SUPPORTED -DIGFX_LNL_SUPPORTED -DIGFX_MTL_SUPPORTED -DIGFX_PTL_SUPPORTED -DIGFX_XE2_HPG_SUPPORTED -DIGFX_XEHP_SDV_SUPPORTED -DIGFX_XE_HPG_SUPPORTED -DMEDIA_VERSION=\"25.4.0\" -DMEDIA_VERSION_DETAILS=\"fe7dda31a9\" -DVEBOX_AUTO_DENOISE_SUPPORTED=1 -D_AV1_DECODE_SUPPORTED -D_AV1_ENCODE_VDENC_SUPPORTED -D_AVC_DECODE_SUPPORTED -D_AVC_ENCODE_VDENC_SUPPORTED -D_AVC_ENCODE_VME_SUPPORTED -D_COMMON_ENCODE_SUPPORTED -D_DECODE_PROCESSING_SUPPORTED -D_HEVC_DECODE_SUPPORTED -D_HEVC_ENCODE_VDENC_SUPPORTED -D_HEVC_ENCODE_VME_SUPPORTED -D_JPEG_DECODE_SUPPORTED -D_JPEG_ENCODE_SUPPORTED -D_MPEG2_DECODE_SUPPORTED -D_MPEG2_ENCODE_VME_SUPPORTED -D_RELEASE -D_VC1_DECODE_SUPPORTED -D_VP8_DECODE_SUPPORTED -D_VP8_ENCODE_SUPPORTED -D_VP9_DECODE_SUPPORTED -D_VP9_ENCODE_VDENC_SUPPORTED -D_VVC_DECODE_SUPPORTED -D__STDC_CONSTANT_MACROS -D__STDC_LIMIT_MACROS -D__VPHAL_SFC_SUPPORTED=1 -tEC-Generic.x86_64-13.0-devel/build/media-driver-25.4.0/media_softlet/linux/xe3_lpm_r0/decode/vvc/ddi y -virtual-dtor -Wno-invalid-offsetof -fvisibility-inlines-hidden -fno-use-cxa-atexit -frtti -fexceptions -fpermissive -fcheck-new -std=c++1y -std=c++11 -fPIC -Werror -Wall -Winit-self -Wpointer-arith -Wno-unused -Wno-unknown-pragmas -Wno-comments -Wno-sign-compare -Wno-attributes -Wno-narrowing -Wno-overflow -Wno-parentheses -Wno-delete-incomplete -Werror=address -Werror=format-security -Werror=non-virtual-dtor -Werror=return-type -Wno-overloaded-virtual -finline-functions -funswitch-loops -fno-short-enums -Wa,--noexecstack -fno-strict-aliasing -fmessage-length=0 -fvisibility=hidden -fdata-sections -ffunction-sections -Wl,--gc-sections -std=c++14 -m64 -DLINUX=1 -DLINUX -DNO_RTTI -DNO_EXCEPTION_HANDLING -DINTEL_NOT_PUBLIC -g -fstack-protector -D_AMD64_ -D__CT__ -D__linux__ -fno-tree-pre -fPIC -Wl,--no-as-needed -O2 -fno-omit-frame-pointer -D_FORTIFY_SOURCE=2 -finline-limit=100 -MD -MT media_driver/CMakeFiles/iHD_drv_video_COMMON.dir/agnostic/gen8/hw/mhw_state_heap_g8.c.o -MF media_driver/CMakeFiles/iHD_drv_video_COMMON.dir/agnostic/gen8/hw/mhw_state_heap_g8.c.o.d -o media_driver/CMakeFiles/iHD_drv_video_COMMON.dir/agnostic/gen8/hw/mhw_state_heap_g8.c.o -c /var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/build/media-driver-25.4.0/media_driver/agnostic/gen8/hw/mhw_state_heap_g8.c
../media_driver/agnostic/gen8/hw/mhw_state_heap_g8.c: In member function 'virtual MOS_STATUS MHW_STATE_HEAP_INTERFACE_G8_X::AddSamplerStateData(uint32_t, MemoryBlock*, PMHW_SAMPLER_STATE_PARAM)':
../media_driver/agnostic/gen8/hw/mhw_state_heap_g8.c:834:38: error: storing the address of local variable 'indirectState' in '*pParam._MHW_SAMPLER_STATE_PARAM::<anonymous>._MHW_SAMPLER_STATE_PARAM::<unnamed union>::Unorm._MHW_SAMPLER_STATE_UNORM_PARAM::pIndirectState' [-Werror=dangling-pointer=]
  834 |         pParam->Unorm.pIndirectState = &indirectState;
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
../media_driver/agnostic/gen8/hw/mhw_state_heap_g8.c:832:57: note: 'indirectState' declared here
  832 |         mhw_state_heap_g8_X::SAMPLER_INDIRECT_STATE_CMD indirectState;
      |                                                         ^~~~~~~~~~~~~
../media_driver/agnostic/gen8/hw/mhw_state_heap_g8.c:822:33: note: 'pParam' declared here
  822 |     PMHW_SAMPLER_STATE_PARAM    pParam)
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
cc1plus: all warnings being treated as errors

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions