Skip to content

The default for connect and order of arguments are different on addPortMap for BridgeModule and InterfaceReference #12

@mkorbel1

Description

@mkorbel1

Describe the bug

It's confusing to have a different default and positional argument order between two effectively identical functions on different classes (one calls the other). These should be made consistent.

// in BridgeModule
  PortMap addPortMap(PortReference port, InterfacePortReference intfPort,
          {bool connect = false}) =>

// in InterfaceReference
  PortMap addPortMap(InterfacePortReference interfacePort, PortReference port,
      {bool connect = true}) {

This would be a breaking change, unfortunately

To Reproduce

No response

Expected behavior

No response

Actual behavior

No response

Additional: Dart SDK info

No response

Additional: pubspec.yaml

Additional: Context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions