fix #33 - avoid <SUBSCRIPT> error

Author: bdeboe

build-for-zpm/ClassExplorer/ClassView.cls

@@ -321,14 +321,25 @@ ClassMethod getBaseOData(packageName As %String, baseNamespace As %String, saved
 
     set ns = $namespace
     zn baseNamespace
-    if $get(^ClassExplorer("savedView", ns_":"_savedName)) '= "" {
-        set oData.savedView = $get(^ClassExplorer("savedView", ns_":"_savedName))
+    set shortName = ..shortenSavedName(ns_":"_savedName)
+    if $get(^ClassExplorer("savedView", shortName)) '= "" {
+        set oData.savedView = $get(^ClassExplorer("savedView", shortName))
     }
     zn ns
 
     quit oData
 }
 
+/// Shorten the saved name to avoid SUBSCRIPT errors when saving into ^ClassExplorer
+ClassMethod shortenSavedName(savedName as %String) As %String [ Internal ]
+{
+    // this is not watertight, but should be sufficient for this use case
+    if $l(savedName)>100 {
+        return $e(savedName, 1, 100) _ $zcrc(savedName, 7)
+    }
+    return savedName
+}
+
 /// Returns if class with given name exists.
 ClassMethod classExists(className As %String) As %Boolean
 {

build-for-zpm/ClassExplorer/Router.cls

@@ -42,7 +42,7 @@ ClassMethod SaveView() As %Status
 {
     set name = %request.Get("name")
     set content = %request.Content.Read($$$MaxStringLength) // ~ 7mb
-    set ^ClassExplorer("savedView", name) = content
+    set ^ClassExplorer("savedView", ##class(ClassExplorer.ClassView).shortenSavedName(name)) = content
     write "{""OK"":true}"
     return $$$OK
 }
@@ -51,7 +51,7 @@ ClassMethod SaveView() As %Status
 ClassMethod ResetView() As %Status
 {
     set name = %request.Get("name")
-    kill ^ClassExplorer("savedView", name)
+    kill ^ClassExplorer("savedView", ##class(ClassExplorer.ClassView).shortenSavedName(name))
     write "{""OK"":true}"
     return $$$OK
 }

src/cls/ClassExplorer/ClassView.cls

@@ -321,14 +321,25 @@ ClassMethod getBaseOData(packageName As %String, baseNamespace As %String, saved
 
     set ns = $namespace
     zn baseNamespace
-    if $get(^ClassExplorer("savedView", ns_":"_savedName)) '= "" {
-        set oData.savedView = $get(^ClassExplorer("savedView", ns_":"_savedName))
+    set shortName = ..shortenSavedName(ns_":"_savedName)
+    if $get(^ClassExplorer("savedView", shortName)) '= "" {
+        set oData.savedView = $get(^ClassExplorer("savedView", shortName))
     }
     zn ns
 
     quit oData
 }
 
+/// Shorten the saved name to avoid SUBSCRIPT errors when saving into ^ClassExplorer
+ClassMethod shortenSavedName(savedName as %String) As %String [ Internal ]
+{
+    // this is not watertight, but should be sufficient for this use case
+    if $l(savedName)>100 {
+        return $e(savedName, 1, 100) _ $zcrc(savedName, 7)
+    }
+    return savedName
+}
+
 /// Returns if class with given name exists.
 ClassMethod classExists(className As %String) As %Boolean
 {

src/cls/ClassExplorer/Router.cls

@@ -42,7 +42,7 @@ ClassMethod SaveView() As %Status
 {
     set name = %request.Get("name")
     set content = %request.Content.Read($$$MaxStringLength) // ~ 7mb
-    set ^ClassExplorer("savedView", name) = content
+    set ^ClassExplorer("savedView", ##class(ClassExplorer.ClassView).shortenSavedName(name)) = content
     write "{""OK"":true}"
     return $$$OK
 }
@@ -51,7 +51,7 @@ ClassMethod SaveView() As %Status
 ClassMethod ResetView() As %Status
 {
     set name = %request.Get("name")
-    kill ^ClassExplorer("savedView", name)
+    kill ^ClassExplorer("savedView", ##class(ClassExplorer.ClassView).shortenSavedName(name))
     write "{""OK"":true}"
     return $$$OK
 }