From 8ffae96acd2f72d875e6d325f48a5efd18148ce7 Mon Sep 17 00:00:00 2001
From: Noe Thalheim <noe@thalheim.email>
Date: Thu, 20 Nov 2025 12:27:29 +0100
Subject: [PATCH] Remove NJH6D3T4YV reference from project.pbxproj

Add GitHub Action to make sure this won't happen again
---
 .github/workflows/verify-config.yml | 45 +++++++++++++++++++++++++++++
 CubeSight.xcodeproj/project.pbxproj |  4 +--
 2 files changed, 47 insertions(+), 2 deletions(-)
 create mode 100644 .github/workflows/verify-config.yml

diff --git a/.github/workflows/verify-config.yml b/.github/workflows/verify-config.yml
new file mode 100644
index 0000000..371ce16
--- /dev/null
+++ b/.github/workflows/verify-config.yml
@@ -0,0 +1,45 @@
+name: Verify Build Configuration
+on:
+  pull_request:
+    paths:
+      - "CubeSight.xcodeproj/project.pbxproj"
+      - ".github/workflows/verify-config.yml"
+
+jobs:
+  verify-development-team-uses-variables:
+    name: Verify Development Team Configuration
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Check DEVELOPMENT_TEAM configuration
+        run: |
+          echo "Checking DEVELOPMENT_TEAM configuration..."
+
+          # Find all DEVELOPMENT_TEAM assignments
+          TEAM_LINES=$(grep -n "DEVELOPMENT_TEAM = " CubeSight.xcodeproj/project.pbxproj || true)
+
+          if [ -z "$TEAM_LINES" ]; then
+            echo "⚠️  No DEVELOPMENT_TEAM found in project"
+            exit 0
+          fi
+
+          echo "Found DEVELOPMENT_TEAM entries:"
+          echo "$TEAM_LINES"
+          echo ""
+
+          # Check for lines that DON'T use variable reference syntax
+          BAD_LINES=$(echo "$TEAM_LINES" | grep -v 'DEVELOPMENT_TEAM = "$(DEVELOPMENT_TEAM)";' || true)
+
+          if [ -n "$BAD_LINES" ]; then
+            echo "❌ Found DEVELOPMENT_TEAM entries not using variable reference:"
+            echo "$BAD_LINES"
+            echo ""
+            echo "All entries should use: DEVELOPMENT_TEAM = \"\$(DEVELOPMENT_TEAM)\";"
+            echo ""
+            echo "This ensures the team ID comes from Xcode's build settings"
+            echo "rather than being hardcoded in the project file."
+            exit 1
+          fi
+
+          echo "✅ All DEVELOPMENT_TEAM entries correctly use variable references"
diff --git a/CubeSight.xcodeproj/project.pbxproj b/CubeSight.xcodeproj/project.pbxproj
index c2e6216..5413a0d 100644
--- a/CubeSight.xcodeproj/project.pbxproj
+++ b/CubeSight.xcodeproj/project.pbxproj
@@ -325,7 +325,7 @@
 				CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 				COPY_PHASE_STRIP = NO;
 				DEBUG_INFORMATION_FORMAT = dwarf;
-				DEVELOPMENT_TEAM = NJH6D3T4YV;
+				DEVELOPMENT_TEAM = "$(DEVELOPMENT_TEAM)";
 				ENABLE_STRICT_OBJC_MSGSEND = YES;
 				ENABLE_TESTABILITY = YES;
 				ENABLE_USER_SCRIPT_SANDBOXING = YES;
@@ -390,7 +390,7 @@
 				CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 				COPY_PHASE_STRIP = NO;
 				DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
-				DEVELOPMENT_TEAM = NJH6D3T4YV;
+				DEVELOPMENT_TEAM = "$(DEVELOPMENT_TEAM)";
 				ENABLE_NS_ASSERTIONS = NO;
 				ENABLE_STRICT_OBJC_MSGSEND = YES;
 				ENABLE_USER_SCRIPT_SANDBOXING = YES;