add repo-wide clippy lints

rbalicki2 · rbalicki2 · commit 5074a8e963b9 · 2025-11-20T10:12:06.000-05:00
diff --git a/Cargo.toml b/Cargo.toml
@@ -67,3 +67,7 @@ codegen-units = 1
 opt-level = "s"
 # Strip debug symbols
 strip = "symbols"
+
+[workspace.lints.clippy]
+print_stderr = "deny"
+print_stdout = "deny"
diff --git a/crates/artifact_content/Cargo.toml b/crates/artifact_content/Cargo.toml
@@ -21,3 +21,6 @@ serde = { workspace = true }
 serde_json = { workspace = true }
 thiserror = { workspace = true }
 tracing = { workspace = true }
+
+[lints]
+workspace = true
diff --git a/crates/common_lang_types/Cargo.toml b/crates/common_lang_types/Cargo.toml
@@ -11,3 +11,6 @@ string_key_newtype = { path = "../string_key_newtype" }
 pico = { path = "../pico" }
 serde = { workspace = true }
 pathdiff = { workspace = true }
+
+[lints]
+workspace = true
diff --git a/crates/graphql_lang_types/Cargo.toml b/crates/graphql_lang_types/Cargo.toml
@@ -10,3 +10,6 @@ common_lang_types = { path = "../common_lang_types" }
 strum = { workspace = true }
 serde = { workspace = true }
 thiserror = { workspace = true }
+
+[lints]
+workspace = true
diff --git a/crates/graphql_network_protocol/Cargo.toml b/crates/graphql_network_protocol/Cargo.toml
@@ -18,3 +18,6 @@ lazy_static = { workspace = true }
 pathdiff = { workspace = true }
 thiserror = { workspace = true }
 tracing = { workspace = true }
+
+[lints]
+workspace = true
diff --git a/crates/graphql_schema_parser/Cargo.toml b/crates/graphql_schema_parser/Cargo.toml
@@ -11,3 +11,6 @@ graphql_lang_types = { path = "../graphql_lang_types" }
 common_lang_types = { path = "../common_lang_types" }
 logos = { workspace = true }
 thiserror = { workspace = true }
+
+[lints]
+workspace = true
diff --git a/crates/impl_base_types_macro/Cargo.toml b/crates/impl_base_types_macro/Cargo.toml
@@ -11,3 +11,6 @@ syn = { workspace = true }
 
 [lib]
 proc-macro = true
+
+[lints]
+workspace = true
diff --git a/crates/isograph_cli/Cargo.toml b/crates/isograph_cli/Cargo.toml
@@ -25,3 +25,6 @@ tracing-subscriber = { workspace = true }
 tracing-opentelemetry = { workspace = true }
 opentelemetry = { workspace = true }
 opentelemetry-otlp = { workspace = true }
+
+[lints]
+workspace = true
diff --git a/crates/isograph_compiler/Cargo.toml b/crates/isograph_compiler/Cargo.toml
@@ -24,3 +24,6 @@ regex = { workspace = true }
 thiserror = { workspace = true }
 tokio = { workspace = true }
 tracing = { workspace = true }
+
+[lints]
+workspace = true
diff --git a/crates/isograph_compiler/src/watch.rs b/crates/isograph_compiler/src/watch.rs
@@ -11,7 +11,7 @@ use notify_debouncer_full::{
 };
 use std::{path::PathBuf, time::Duration};
 use tokio::{runtime::Handle, sync::mpsc::Receiver};
-use tracing::info;
+use tracing::{info, warn};
 
 use crate::{
     batch_compile::{BatchCompileError, compile, print_result},
@@ -251,7 +251,7 @@ pub fn create_debounced_file_watcher(
                 let sender = sender.clone();
                 current_runtime.spawn(async move {
                     if let Err(e) = sender.send(events).await {
-                        println!("Error sending event result: {e:?}");
+                        warn!("Error sending event result: {e:?}");
                     }
                 });
             }
diff --git a/crates/isograph_config/Cargo.toml b/crates/isograph_config/Cargo.toml
@@ -19,3 +19,6 @@ schemars = { workspace = true }
 serde = { workspace = true }
 serde_json = { workspace = true }
 tracing = { workspace = true }
+
+[lints]
+workspace = true
diff --git a/crates/isograph_fixture_tests/Cargo.toml b/crates/isograph_fixture_tests/Cargo.toml
@@ -19,3 +19,6 @@ pico = { path = "../pico" }
 clap = { workspace = true }
 regex = { workspace = true }
 lazy_static = { workspace = true }
+
+[lints]
+workspace = true
diff --git a/crates/isograph_lang_parser/Cargo.toml b/crates/isograph_lang_parser/Cargo.toml
@@ -13,3 +13,6 @@ resolve_position = { path = "../resolve_position" }
 resolve_position_macros = { path = "../resolve_position_macros" }
 logos = { workspace = true }
 thiserror = { workspace = true }
+
+[lints]
+workspace = true
diff --git a/crates/isograph_lang_types/Cargo.toml b/crates/isograph_lang_types/Cargo.toml
@@ -13,3 +13,6 @@ resolve_position_macros = { path = "../resolve_position_macros" }
 lsp-types = { workspace = true }
 serde = { workspace = true }
 thiserror = { workspace = true }
+
+[lints]
+workspace = true
diff --git a/crates/isograph_lsp/Cargo.toml b/crates/isograph_lsp/Cargo.toml
@@ -29,3 +29,6 @@ thiserror = { workspace = true }
 tokio = { workspace = true, features = ["full", "test-util", "tracing"] }
 tracing = { workspace = true }
 url = { workspace = true }
+
+[lints]
+workspace = true
diff --git a/crates/isograph_lsp/src/server.rs b/crates/isograph_lsp/src/server.rs
@@ -35,6 +35,7 @@ use lsp_types::{
 };
 use std::{ops::ControlFlow, path::PathBuf};
 use thiserror::Error;
+use tracing::debug;
 
 /// Initializes an LSP connection, handling the `initialize` message and `initialized` notification
 /// handshake.
@@ -74,7 +75,7 @@ pub async fn run<TNetworkProtocol: NetworkProtocol>(
     let mut compiler_state: CompilerState<TNetworkProtocol> =
         CompilerState::new(config_location, current_working_directory)?;
 
-    eprintln!("Running server loop");
+    debug!("Running server loop");
 
     let (tokio_sender, mut lsp_message_receiver) = tokio::sync::mpsc::channel(100);
     bridge_crossbeam_to_tokio(connection.receiver, tokio_sender);
@@ -91,21 +92,21 @@ pub async fn run<TNetworkProtocol: NetworkProtocol>(
                     let duration = WithDuration::new(|| {
                         match lsp_message {
                             lsp_server::Message::Request(request) => {
-                                eprintln!("\nReceived request: {}", request.method);
+                                debug!("\nReceived request: {}", request.method);
                                 let response = dispatch_request(request, &compiler_state);
-                                eprintln!("Sending response: {response:?}");
+                                debug!("Sending response: {response:?}");
                                 connection.sender.send(response.into()).unwrap();
                             }
                             lsp_server::Message::Notification(notification) => {
-                                eprintln!("\nReceived notification: {}", notification.method);
+                                debug!("\nReceived notification: {}", notification.method);
                                 let _ = dispatch_notification(notification, &mut compiler_state);
                             }
                             lsp_server::Message::Response(response) => {
-                                eprintln!("\nReceived response: {response:?}");
+                                debug!("\nReceived response: {response:?}");
                             }
                         }
                     });
-                    eprintln!("Processing took {}ms.", duration.elapsed_time.as_millis());
+                    debug!("Processing took {}ms.", duration.elapsed_time.as_millis());
                 } else {
                     // If any connection breaks, we can just end
                     break 'all_messages;
diff --git a/crates/isograph_schema/Cargo.toml b/crates/isograph_schema/Cargo.toml
@@ -21,3 +21,6 @@ regex = { workspace = true }
 serde = { workspace = true }
 thiserror = { workspace = true }
 tracing = { workspace = true }
+
+[lints]
+workspace = true
diff --git a/crates/pico/Cargo.toml b/crates/pico/Cargo.toml
@@ -17,3 +17,6 @@ serde_derive = { workspace = true }
 thiserror = { workspace = true }
 tinyvec = { workspace = true, features = ["serde"] }
 tracing = { workspace = true }
+
+[lints]
+workspace = true
diff --git a/crates/pico_macros/Cargo.toml b/crates/pico_macros/Cargo.toml
@@ -13,3 +13,6 @@ syn = { workspace = true }
 
 [lib]
 proc-macro = true
+
+[lints]
+workspace = true
diff --git a/crates/resolve_position/Cargo.toml b/crates/resolve_position/Cargo.toml
@@ -7,3 +7,6 @@ license = { workspace = true }
 
 [dependencies]
 common_lang_types = { path = "../common_lang_types" }
+
+[lints]
+workspace = true
diff --git a/crates/resolve_position_macros/Cargo.toml b/crates/resolve_position_macros/Cargo.toml
@@ -13,3 +13,6 @@ syn = { workspace = true }
 
 [lib]
 proc-macro = true
+
+[lints]
+workspace = true
diff --git a/crates/string_key_newtype/Cargo.toml b/crates/string_key_newtype/Cargo.toml
@@ -5,3 +5,6 @@ edition = { workspace = true }
 license = { workspace = true }
 
 [dependencies]
+
+[lints]
+workspace = true
diff --git a/crates/swc_isograph_plugin/Cargo.toml b/crates/swc_isograph_plugin/Cargo.toml
@@ -34,3 +34,6 @@ tracing = { workspace = true }
 swc_ecma_parser = { workspace = true }
 swc_ecma_transforms_testing = { workspace = true }
 testing = { workspace = true }
+
+[lints]
+workspace = true
diff --git a/crates/tests/Cargo.toml b/crates/tests/Cargo.toml
@@ -19,3 +19,6 @@ serde = { workspace = true }
 
 [dev-dependencies]
 graphql_schema_parser = { path = "../graphql_schema_parser" }
+
+[lints]
+workspace = true
diff --git a/crates/u64_newtypes/Cargo.toml b/crates/u64_newtypes/Cargo.toml
@@ -7,3 +7,6 @@ license = { workspace = true }
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
 [dependencies]
+
+[lints]
+workspace = true
diff --git a/tree-sitter/Cargo.toml b/tree-sitter/Cargo.toml
