Merge branch 'main' into release/2.0.0

Author: olivhoenen

CONTRIBUTING.md

@@ -9,28 +9,28 @@ Please first make sure you read and follow the
 ## You think you found a bug in the code, or have a question in its use
 1. use the [issue search](https://github.com/iterorganization/IMAS-Python/issues)
 to check if someone already created a similar issue;
-3. if not, make a **new issue** to describe your problem or question. 
+2. if not, make a **new issue** to describe your problem or question. 
 In the case of a bug suspiscion, please try to give all the relevant 
 information to allow reproducing the error or identifying 
 its root cause (version of the IMAS-Python, OS and relevant 
 dependencies, snippet of code);
-4. apply relevant labels to the issue.
+3. apply relevant labels to the issue.
 
 ## You want to make or ask some change to the code
 1. use the [issue search](https://github.com/iterorganization/IMAS-Python/issues)
 to check if someone already proposed a similar idea/change;
-3. if not, create a **new issue** to describe what change you would like to see 
+2. if not, create a **new issue** to describe what change you would like to see 
 implemented and specify it if you intend to work on it yourself or if some help 
 will be needed;
-4. wait until some kind of consensus is reached about your idea being relevant, 
+3. wait until some kind of consensus is reached about your idea being relevant, 
 at which time the issue will be assigned (to you or someone else who can work on 
 this topic);
-5. if you do the development yourself, fork the repository to your own Github 
+4. if you do the development yourself, fork the repository to your own Github 
 profile and create your own feature branch off of the latest develop commit. 
 Make sure to regularly sync your branch with the latest commits from `develop` 
 (find instructions 
 [here](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork));
-6. when your development is ready, create a pull request (find instructions 
+5. when your development is ready, create a pull request (find instructions 
 [here](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork)).
 
 

README.md

@@ -28,11 +28,17 @@ factory = imas.IDSFactory()
 equilibrium = factory.equilibrium()
 print(equilibrium)
 
-equilibrium.ids_properties.homogeneous_time = imas.ids_defs.IDS_TIME_MODE_HETEROGENEOUS
+equilibrium.ids_properties.homogeneous_time = imas.ids_defs.IDS_TIME_MODE_HOMOGENEOUS
 equilibrium.ids_properties.comment = "testing"
+equilibrium.time = [0.01]
 
 with imas.DBEntry("imas:hdf5?path=./testdb","w") as dbentry:
     dbentry.put(equilibrium)
+	
+# or without imas_core dependency
+with imas.DBEntry("./test.nc","w") as dbentry:
+    dbentry.put(equilibrium)
+
 ```
 
 A quick 5 minutes introduction is available in the documentation generated from `/docs/sources/intro.rst`.

imas/backends/db_entry_impl.py

@@ -36,6 +36,30 @@ class GetSampleParameters:
     """See :param:`imas.db_entry.DBEntry.get_sample.interpolation_method`."""
 
 
+@dataclass
+class GetSliceParameters:
+    """Helper class to store parameters to get_slice."""
+
+    time_requested: float
+    """See :param:`imaspy.db_entry.DBEntry.get_slice.time_requested`."""
+    interpolation_method: int
+    """See :param:`imaspy.db_entry.DBEntry.get_slice.interpolation_method`."""
+
+
+@dataclass
+class GetSampleParameters:
+    """Helper class to store parameters to get_sample."""
+
+    tmin: float
+    """See :param:`imaspy.db_entry.DBEntry.get_sample.tmin`."""
+    tmax: float
+    """See :param:`imaspy.db_entry.DBEntry.get_sample.tmax`."""
+    dtime: Optional[numpy.ndarray]
+    """See :param:`imaspy.db_entry.DBEntry.get_sample.dtime`."""
+    interpolation_method: Optional[int]
+    """See :param:`imaspy.db_entry.DBEntry.get_sample.interpolation_method`."""
+
+
 class DBEntryImpl(ABC):
     """Interface for DBEntry implementations."""
 

imas/backends/imas_core/db_entry_helpers.py

@@ -77,11 +77,15 @@ def get_children(
                 getattr(structure, name)._IDSPrimitive__value = data
 
 
-def _get_child(child: IDSBase, ctx: LazyALContext):
+def _get_child(child: IDSBase, ctx: Optional[LazyALContext]):
     """Get a single child when required (lazy loading)."""
     # NOTE: changes in this method must be propagated to _get_children and vice versa
     #   Performance: this method is specialized for the lazy get
 
+    # ctx can be None when the parent structure does not exist in the on-disk DD version
+    if ctx is None:
+        return  # There is no data to be loaded
+
     time_mode = ctx.time_mode
     if time_mode == IDS_TIME_MODE_INDEPENDENT and child.metadata.type.is_dynamic:
         return  # skip dynamic (time-dependent) nodes