[pallas:sc] Lower ref indexing to memref.subview instead of tpu.memref_slice and tpu.memref_squeeze #32973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_825583835
branch
from
6150f60 to
7cff622
Compare
…f_slice and tpu.memref_squeeze TPU dialect ops are designed to be used with tiled layouts, which are not yet fully adopted by the SC compiler. In the future, we would probably want a pass which rewrites memref.subview into tpu.memref_slice and tpu.memref_squeeze and replaces the strided layout with tiled. PiperOrigin-RevId: 825583835
copybara-service
bot
force-pushed
the
test_825583835
branch
from
7cff622 to
bd366b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[pallas:sc] Lower ref indexing to memref.subview instead of tpu.memref_slice and tpu.memref_squeeze
TPU dialect ops are designed to be used with tiled layouts, which are not yet
fully adopted by the SC compiler.
In the future, we would probably want a pass which rewrites memref.subview
into tpu.memref_slice and tpu.memref_squeeze and replaces the strided layout
with tiled.