Skip to content

Commit 1a1e87b

Browse files
authored
Migrate gitlab api from 5 to 6 (#511)
* Bump gitlab-api from 5.8.1-106.vef1de800710e from 6.1.0-106.v6c0b_5b_df4ee6 * Migrates classes from GitLab API 5 to 6 * Bump Jackson2 API plugin from 2.20.0-417.va_5311a_823a_b_8 to 2.20.0-420.v8a_08b_d57ca_05 * Bump GitLab API plugin from 6.1.0-106.v6c0b_5b_df4ee6 to 6.1.0-109.v6d933577c873 * Bump jenkins.version from 2.479.3 to 2.504.3 * Bump bom version from 5473.vb_9533d9e5d88 to 5543.vfd758c7c868d * Puts gitlab-api plugin version in dependency management * Bump gitlab-api from 6.1.0-109.v6d933577c873 to 6.1.0-118.v78e2a_35b_f209 * Bump gitlab-api to 6.2.0-111.vf174d6b_8c12e * Bump BOM to 5681.v79d2ddf61465
1 parent 6e30226 commit 1a1e87b

File tree

4 files changed

+14
-11
lines changed

4 files changed

+14
-11
lines changed

pom.xml

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
<properties>
3333
<changelist>999999-SNAPSHOT</changelist>
3434
<!-- https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/ -->
35-
<jenkins.baseline>2.492</jenkins.baseline>
35+
<jenkins.baseline>2.504</jenkins.baseline>
3636
<jenkins.version>${jenkins.baseline}.3</jenkins.version>
3737
<gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo>
3838
<spotless.check.skip>false</spotless.check.skip>
@@ -46,10 +46,16 @@
4646
<dependency>
4747
<groupId>io.jenkins.tools.bom</groupId>
4848
<artifactId>bom-${jenkins.baseline}.x</artifactId>
49-
<version>5054.v620b_5d2b_d5e6</version>
49+
<version>5681.v79d2ddf61465</version>
5050
<type>pom</type>
5151
<scope>import</scope>
5252
</dependency>
53+
<!-- TODO Remove once in BOM -->
54+
<dependency>
55+
<groupId>io.jenkins.plugins</groupId>
56+
<artifactId>gitlab-api</artifactId>
57+
<version>6.2.0-111.vf174d6b_8c12e</version>
58+
</dependency>
5359
</dependencies>
5460
</dependencyManagement>
5561

@@ -61,7 +67,6 @@
6167
<dependency>
6268
<groupId>io.jenkins.plugins</groupId>
6369
<artifactId>gitlab-api</artifactId>
64-
<version>5.8.1-106.vef1de800710e</version>
6570
</dependency>
6671
<dependency>
6772
<groupId>org.jenkins-ci.plugins</groupId>

src/main/java/io/jenkins/plugins/gitlabbranchsource/GitLabSCMSource.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,6 @@
8585
import jenkins.scm.impl.trait.Discovery;
8686
import jenkins.scm.impl.trait.Selection;
8787
import org.apache.commons.lang3.StringUtils;
88-
import org.gitlab4j.api.Constants;
89-
import org.gitlab4j.api.Constants.MergeRequestState;
9088
import org.gitlab4j.api.GitLabApi;
9189
import org.gitlab4j.api.GitLabApiException;
9290
import org.gitlab4j.api.models.AccessLevel;
@@ -96,6 +94,8 @@
9694
import org.gitlab4j.api.models.Project;
9795
import org.gitlab4j.api.models.ProjectFilter;
9896
import org.gitlab4j.api.models.Tag;
97+
import org.gitlab4j.models.Constants;
98+
import org.gitlab4j.models.Constants.MergeRequestState;
9999
import org.jenkins.ui.icon.IconSpec;
100100
import org.jenkinsci.Symbol;
101101
import org.jenkinsci.plugins.gitclient.GitClient;

src/main/java/io/jenkins/plugins/gitlabbranchsource/GitLabSystemHookAction.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,8 @@
2121
import jenkins.scm.api.SCMEvent;
2222
import org.apache.commons.lang3.StringUtils;
2323
import org.gitlab4j.api.GitLabApiException;
24-
import org.gitlab4j.api.systemhooks.SystemHookManager;
24+
import org.gitlab4j.api.SystemHookManager;
2525
import org.kohsuke.stapler.HttpResponse;
26-
import org.kohsuke.stapler.StaplerRequest;
2726
import org.kohsuke.stapler.StaplerRequest2;
2827

2928
@Extension
@@ -81,7 +80,7 @@ public HttpResponse doPost(StaplerRequest2 request) throws GitLabApiException {
8180
String origin = SCMEvent.originOf(request);
8281
SystemHookManager systemHookManager = new SystemHookManager();
8382
systemHookManager.addListener(new GitLabSystemHookListener(origin));
84-
systemHookManager.handleEvent(StaplerRequest.fromStaplerRequest2(request));
83+
systemHookManager.handleEvent(request);
8584
return HttpResponses.ok(); // TODO find a better response
8685
}
8786

src/main/java/io/jenkins/plugins/gitlabbranchsource/GitLabWebHookAction.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,8 @@
2121
import jenkins.scm.api.SCMEvent;
2222
import org.apache.commons.lang3.StringUtils;
2323
import org.gitlab4j.api.GitLabApiException;
24-
import org.gitlab4j.api.webhook.WebHookManager;
24+
import org.gitlab4j.api.WebHookManager;
2525
import org.kohsuke.stapler.HttpResponse;
26-
import org.kohsuke.stapler.StaplerRequest;
2726
import org.kohsuke.stapler.StaplerRequest2;
2827

2928
@Extension
@@ -81,7 +80,7 @@ public HttpResponse doPost(StaplerRequest2 request) throws IOException, GitLabAp
8180
String origin = SCMEvent.originOf(request);
8281
WebHookManager webHookManager = new WebHookManager();
8382
webHookManager.addListener(new GitLabWebHookListener(origin));
84-
webHookManager.handleEvent(StaplerRequest.fromStaplerRequest2(request));
83+
webHookManager.handleEvent(request);
8584
return HttpResponses.ok(); // TODO find a better response
8685
}
8786

0 commit comments

Comments
 (0)