Commit 9eba0e3
## Summary
The old code used shell '&' to background mysqld, then captured its pid
with MYSQL_PID=$!, in doing so obscuring the mysqld exit code.
I can't see any sane way of both propagating the exit code *and* setting
MYSQL_PID. I also can't see any point in MYSQL_PID, given that
process-compose is a TUI and the pid is readily available in
$MYSQL_PID_FILE. So to fix the bug, I've made mysqld no longer
backgrounded (hence `is_daemon` becomes 'false').
## How was it tested?
Testing is as in the description of #2518: set up mysqld to fail (e.g.
claim port 3306) and `devbox services up`.
The mysqld process *ought* to go into a failure loop, toggling between
status 'Restarting' and 'Running' and setting exit code 1.
(It's not related to this patch, but I suggest also limiting these
infinite restarts by setting `max_restarts`, e.g.:
```
availability:
restart: "always"
max_restarts: 5
```
)
---------
Co-authored-by: John Lago <750845+Lagoja@users.noreply.github.com>
1 parent 25ea082 commit 9eba0e3
File tree
2 files changed
+4
-4
lines changed- plugins
- mariadb
- mysql
2 files changed
+4
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
6 | | - | |
| 5 | + | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
6 | | - | |
| 5 | + | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| |||
0 commit comments