From 3f01b0411426ebdea5241943ae759f1c47222eee Mon Sep 17 00:00:00 2001
From: Andrew Jackman <andrew@lbcit.ca>
Date: Wed, 22 Jan 2025 21:29:18 -0600
Subject: [PATCH 1/3] Update module.xml fix spelling of license

Fix spelling of licence to license in module.xml (otherwise error in /var/www/html/admin/libraries/BMO/GuiHooks.class.php line 250)
---
 module.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/module.xml b/module.xml
index 4c17e8c..a018d93 100644
--- a/module.xml
+++ b/module.xml
@@ -6,7 +6,7 @@
 	<category>Development</category>
 	<Publisher>James Finstrom</Publisher>
 	<info>http://wiki.freepbx.org/pages/viewpage.action?pageId=19498386</info>
-	<licence>GPL</licence>
+	<license>GPL</license>
 	<licenselink>http://www.gnu.org/licenses/gpl-2.0.txt</licenselink>
 	<database>
         	<table name="helloworld">

From acf9f6807d5ce0d2c6a50866e598c6d2786e2c7e Mon Sep 17 00:00:00 2001
From: Andrew Jackman <andrew@lbcit.ca>
Date: Wed, 22 Jan 2025 21:30:22 -0600
Subject: [PATCH 2/3] Update Helloworld.class.php add isset($_REQUEST['view'])

Added isset($_REQUEST['view']) to /var/www/html/admin/modules/helloworld/Helloworld.class.php line 279
---
 Helloworld.class.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Helloworld.class.php b/Helloworld.class.php
index 52a98d0..5832a83 100644
--- a/Helloworld.class.php
+++ b/Helloworld.class.php
@@ -276,7 +276,7 @@ public function showPage()
 		$subhead = _('Item List');
 		$content = load_view(__DIR__ . '/views/grid.php');
 
-		if ('form' == $_REQUEST['view']) {
+		if (isset($_REQUEST['view']) && 'form' == $_REQUEST['view']) {
 			$subhead = _('Add Item');
 			$content = load_view(__DIR__ . '/views/form.php');
 			if (isset($_REQUEST['id']) && !empty($_REQUEST['id'])) {

From b6ea6034c6bd0386b2c655ecd695317524c32c75 Mon Sep 17 00:00:00 2001
From: Andrew Jackman <andrew@lbcit.ca>
Date: Wed, 22 Jan 2025 21:31:46 -0600
Subject: [PATCH 3/3] Update form.php add issets to all variables

Add isset to check for $id, $subject and $body as well as pull up </textarea> to stop adding default space
---
 views/form.php | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/views/form.php b/views/form.php
index 7635441..d35f52c 100644
--- a/views/form.php
+++ b/views/form.php
@@ -1,5 +1,5 @@
-<form action="" method="post" class="fpbx-submit" id="hwform" name="hwform" data-fpbx-delete="config.php?display=helloworld&action=delete&id=<?php echo $id?>">
-<input type="hidden" name='action' value="<?php echo $id?'edit':'add' ?>">
+<form action="" method="post" class="fpbx-submit" id="hwform" name="hwform" data-fpbx-delete="config.php?display=helloworld&action=delete&id=<?php echo isset($id) ? $id : '' ?>">
+<input type="hidden" name='action' value="<?php echo ( isset($id) && $id ) ? 'edit' : 'add' ?>">
 <!--Subject-->
 <div class="element-container">
 	<div class="row">
@@ -11,7 +11,7 @@
 						<i class="fa fa-question-circle fpbx-help-icon" data-for="subject"></i>
 					</div>
 					<div class="col-md-9">
-						<input type="text" class="form-control" id="subject" name="subject" value="<?php echo $subject?>">
+						<input type="text" class="form-control" id="subject" name="subject" value="<?php echo isset($subject) ? $subject : '' ?>">
 					</div>
 				</div>
 			</div>
@@ -35,8 +35,7 @@
 						<i class="fa fa-question-circle fpbx-help-icon" data-for="body"></i>
 					</div>
 					<div class="col-md-9">
-						<textarea class="form-control" id="body" name="body"><?php echo $body?>
-						</textarea>
+						<textarea class="form-control" id="body" name="body"><?php echo isset($body) ? $body : '' ?></textarea>
 					</div>
 				</div>
 			</div>
@@ -49,4 +48,4 @@
 	</div>
 </div>
 <!--END Body-->
-</form>
\ No newline at end of file
+</form>