Skip to content

GitHub 'issues/.../comments' API call returns only 30 comments in one go #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gozhev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

GitHub 'issues/.../comments' API call returns only 30 comments in one go #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 48 additions & 15 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,22 +108,55 @@ module.exports = function (token, options, cb) {
}

function getComments (issue, repo, cb) {
var url = ''
if (repo.issue === 'all') {
url = issue.comments_url
} else {
url = base + '/repos/' + repo.user + '/' + repo.name + '/issues/' + repo.issue + '/comments'
issue.comments = []

var get_issues_since = function(since)
{
var url = ''
var query = since === '' ? '' : '?since=' + since

if (repo.issue === 'all') {
url = issue.comments_url + query
} else {
url = base + '/repos/' + repo.user + '/' + repo.name + '/issues/' + repo.issue + '/comments' + query
}

//console.log('request ' + query)

var on_response = function (err, resp, body) {
if (err) return cb(err, 'Error in request for comments.')
var comments = body

/* remove duplicates */
var dups = 0;
if (issue.comments.length > 0 && comments.length > 0) {
var last_id = issue.comments[issue.comments.length - 1].id
while (comments.length > 0 && comments[0].id <= last_id) {
comments.shift()
++dups
}
}
//console.log('got ' + comments.length + ' new comments'
// + (dups ? ' (' + dups + ' duplicates was dropped)' : ''));

issue.comments = issue.comments.concat(comments)
if (comments.length <= 1) {
//console.log('total got ' + issue.comments.length + ' comments')
issue.comments.forEach(function (comment) {
comment.created_at = new Date(comment.created_at).toLocaleDateString()
})
issueData.push(issue)
cb()
} else {
var last = issue.comments[issue.comments.length - 1]
get_issues_since(last.created_at)
}
}

request(url, { json: true, headers: headers }, on_response)
}
request(url, { json: true, headers: headers }, function (err, resp, body) {
if (err) return cb(err, 'Error in request for comments.')

issue.comments = body
issue.comments.forEach(function (comment) {
comment.created_at = new Date(comment.created_at).toLocaleDateString()
})
issueData.push(issue)
cb()
})

get_issues_since('')
}

function writeData (options, cb) {
Expand Down