Fix "Bitmasking for introspection of Objective-C object pointers is strongly discouraged" warning in Xcode 5

[roustem]

.../JSONKit/JSONKit.m:2600:77: warning: bitmasking for introspection of Objective-C object pointers is strongly discouraged [-Wdeprecated-objc-pointer-introspection]
BOOL workAroundMacOSXABIBreakingBug = (JK_EXPECT_F(((NSUInteger)object) & 0x1)) ? YES : NO;
~~~~~~~~~~~~~~~~~~~~ ^
.../JSONKit/JSONKit.m:199:53: note: expanded from macro 'JK_EXPECT_F'

define JK_EXPECT_F(cond) JK_EXPECTED(cond, 0U)

                                                ^

.../JSONKit/JSONKit.m:197:65: note: expanded from macro 'JK_EXPECTED'

define JK_EXPECTED(cond, expect) __builtin_expect((long)(cond), (expect))

[johnz2]

+1

[mikeabdullah]

We (@karelia) would appreciate this being fixed too

[jdberry]

+1

[mralexgray]

+1

Oh, btw, you can shut this up, like so...

#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-objc-pointer-introspection"
BOOL workAroundMacOSXABIBreakingBug = (JK_EXPECT_F(((NSUInteger)object) & 0x1)) ? YES : NO;
#pragma clang diagnostic pop

[jslicari]

+1

[WeeTom]

+1

[vjacheslav-volodko]

+1

[odyth]

For iOS apps I just commented that line out and it hasnt had any negative impact on my app as far as i can tell. Been in production for about 6 months now.

[coveloper]

+1

[ramakula]

+1

[demodit]

+1

[mmcer]

@roustem ,what about
(JK_EXPECT_F(((NSUInteger)object) % 2)) ?

[vchav73]

If you're using JSONKit I suggest you consider migrating to Apple's NSJSONSerialization. It does what JSONKit does, but according to the article below it's faster. Unlike JSONKit, it's also being maintained. The only downside I'm aware of is that it's only available in iOS 5+ / OS X 10.7+.

http://stackoverflow.com/questions/16218583/jsonkit-benchmarks

[abhibeckert]

@vchav73 it's also not entirely clear it's faster. That test you linked to only showed a slight performance difference and was run in the simulator, so complied for x86 instead of ARM.

There is also another comment that NSJSONSerialization is only fast on iOS 6, not 5. On 5 it was definitely too slow.

Since I'm decoding megabytes of JSON at a time, it's pretty important to me... when I get a chance I'll test it out and post an update here. Unless someone else beats me to it.

[jslicari]

In my experience NSJSONSerialization can be a bit buggy on iOS 5. I have definite cases of perfectly valid JSON that crap out on iOS 5 (produce a nil result) but work fine on iOS 6. So if your app is does not need to support iOS 5 or less I would say definitely migrate to NSJSONSerialization. Otherwise I would keep using JSONKit.

And if you really want to get rid of the JSONKit warning, I found that just putting these #pragma statements around the offending line does the trick:

#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-objc-pointer-introspection"
BOOL workAroundMacOSXABIBreakingBug = (JK_EXPECT_F(((NSUInteger)object) & 0x1)) ? YES : NO;
#pragma clang diagnostic pop