~= is inappropriate

[lilyball]

This is not an appropriate use of ~=. The ~= operator in Swift is called "pattern match", but what it's specifically for is matching values in case statements. The ~= operator is how you can use nil and a..<b intervals in case statements, as well as Equatable values. The code

switch foo {
case 1..<10:
    bar()
default:
    baz()
}

is equivalent to

switch foo {
case temp where 1..<10 ~= temp:
    bar()
default:
    baz()

(except without binding any identifiers).

Repurposing it here as a sort of pattern-match assignment is at the minimum very confusing. You should be using a different custom operator instead.

[zmitchell]

I don't particularly have a problem with ~=, but if you had to change it to something else you could use << or <<<. I think the benefit of something like << becomes apparent in the following example:

var output = input["men"] << "people"

In this example, << indicates that "people" is being inserted in place of "men".

[btelintelo]

I just spent hours tracking a switch/case bug bag to this library. The ~= block of code was causing a switch statement to act very badly, ex:
switch "DONT RUN"
case "RUN"
print("Stop")
case "DON'T RUN"
print("Good")

Because of this library, the first case gets caught and prints Stop. There is no imports to this file anywhere in my project, but because this swift file was in it, it was changing the default behavior of the case statement, which IMHO, is very bad.

[johnno1962]

Fair enough. I’ll remove this overload. Sorry for waisting your time.

[johnno1962]

Done, can you check now?

[btelintelo]

Yeap, that fixed it. Thanks! I inherited this code base and didn't realize that was in there. Not sure why the previous dev was not using enums on the switch statement anyway!

[johnno1962]

Err yes, that did occur to me..