Skip to content

Commit ca179c9

Browse files
author
Helperhaps
committed
format code
1 parent 689d0d0 commit ca179c9

File tree

3 files changed

+19
-34
lines changed

3 files changed

+19
-34
lines changed

jpush/device/core.py

Lines changed: 11 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -12,27 +12,25 @@ def __init__(self, jpush, zone = None):
1212
self.entity = None
1313
self.zone = zone or jpush.zone
1414

15-
def send(self, method, url, body, content_type=None, version=3):
15+
def send(self, method, url, body = None, content_type=None, version=3, params = None):
1616
"""Send the request
1717
1818
"""
19-
response = self._jpush._request(method, body, url, content_type, version=3)
19+
response = self._jpush._request(method, body, url, content_type, version=3, params = params)
2020
return DeviceResponse(response)
2121

2222
def get_taglist(self):
2323
"""Get deviceinfo with registration id.
2424
"""
2525
url = common.get_url('tag', self.zone)
26-
body = None
27-
info = self.send("GET", url, body)
26+
info = self.send("GET", url)
2827
return info
2928

3029
def get_deviceinfo(self, registration_id):
3130
"""Get deviceinfo with registration id.
3231
"""
3332
url = common.get_url('device', self.zone) + registration_id
34-
body = None
35-
info = self.send("GET", url, body)
33+
info = self.send("GET", url)
3634
return info
3735

3836
def set_deviceinfo(self, registration_id, entity):
@@ -55,10 +53,8 @@ def delete_tag(self, tag, platform=None):
5553
"""Delete registration id tag.
5654
"""
5755
url = common.get_url('tag', self.zone) + tag
58-
body = None
59-
if platform:
60-
body = platform
61-
info = self.send("DELETE", url, body)
56+
params = { 'platform': platform } if platform else None
57+
info = self.send("DELETE", url, params = params)
6258
return info
6359

6460
def update_tagusers(self, tag, entity):
@@ -73,28 +69,23 @@ def check_taguserexist(self, tag, registration_id):
7369
"""Check registration id whether in tag.
7470
"""
7571
url = common.get_url('tag', self.zone) + tag + "/registration_ids/" + registration_id
76-
body = registration_id
77-
info = self.send("GET", url, body)
72+
info = self.send("GET", url)
7873
return info
7974

8075
def delete_alias(self, alias, platform=None):
8176
"""Delete appkey alias.
8277
"""
8378
url = common.get_url('alias', self.zone) + alias
84-
body = None
85-
if platform:
86-
body = platform
87-
info = self.send("DELETE", url, body)
79+
params = { 'platform': platform } if platform else None
80+
info = self.send("DELETE", url, params = params)
8881
return info
8982

9083
def get_aliasuser(self, alias, platform=None):
9184
"""Get appkey alias users.
9285
"""
9386
url = common.get_url('alias', self.zone) + alias
94-
body = None
95-
if platform:
96-
body = platform
97-
info = self.send("GET", url, body)
87+
params = { 'platform': platform } if platform else None
88+
info = self.send("GET", url, params = params)
9889
return info
9990

10091

jpush/report/core.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ def __init__(self, jpush, zone = None):
1010
self._jpush = jpush
1111
self.zone = zone or jpush.zone
1212

13-
def send(self, method, url, body, content_type=None, version=3, params = None):
13+
def send(self, method, url, body = None, content_type=None, version=3, params = None):
1414
"""Send the request
1515
"""
1616
response = self._jpush._request(method, body,url,content_type,version=3, params = params)
@@ -19,15 +19,13 @@ def send(self, method, url, body, content_type=None, version=3, params = None):
1919
def get_received(self,msg_ids):
2020
url = common.get_url('report', self.zone) + 'received'
2121
params = { 'msg_ids': msg_ids }
22-
body = None
23-
received = self.send("GET", url, body, params = params)
22+
received = self.send("GET", url, params = params)
2423
return received
2524

2625
def get_messages(self, msg_ids):
2726
url = common.get_url('report', self.zone) + 'messages'
2827
params = { 'msg_ids': msg_ids }
29-
body = None
30-
messages = self.send("GET", url, body, params = params)
28+
messages = self.send("GET", url, params = params)
3129
return messages
3230

3331
def get_users(self, time_unit,start,duration):
@@ -37,8 +35,7 @@ def get_users(self, time_unit,start,duration):
3735
'start': start,
3836
'duration': duration
3937
}
40-
body = None
41-
users = self.send("GET", url, body, params = params)
38+
users = self.send("GET", url, params = params)
4239
return users
4340

4441

jpush/schedule/core.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ def __init__(self, jpush, zone = None):
1111
self._jpush = jpush
1212
self.zone = zone or jpush.zone
1313

14-
def send(self, method, url, body, content_type=None, version=3, params = None):
14+
def send(self, method, url, body = None, content_type=None, version=3, params = None):
1515
response = self._jpush._request(method, body, url, content_type, version=3, params = params)
1616
return ScheduleResponse(response)
1717

@@ -23,15 +23,13 @@ def post_schedule(self, schedulepayload):
2323

2424
def get_schedule_by_id(self, schedule_id):
2525
url = common.get_url('schedule', self.zone) + schedule_id
26-
body = None
27-
result = self.send("GET", url, body)
26+
result = self.send("GET", url)
2827
return result
2928

3029
def get_schedule_list(self, page = 1):
3130
url = common.get_url('schedule', self.zone)
3231
params = { 'page': page }
33-
body = None
34-
result = self.send("GET", url, body, params = params)
32+
result = self.send("GET", url, params = params)
3533
return result
3634

3735
def put_schedule(self, schedulepayload, schedule_id):
@@ -42,8 +40,7 @@ def put_schedule(self, schedulepayload, schedule_id):
4240

4341
def delete_schedule(self,schedule_id):
4442
url = common.get_url('schedule', self.zone) + schedule_id
45-
body = None
46-
result = self.send("DELETE", url, body)
43+
result = self.send("DELETE", url)
4744
return result
4845

4946

0 commit comments

Comments
 (0)