Improve compiler accuracy with detecting "deep sync" when traverse is set to false. Also resolve an async + deterministic compiler issue.

Author: TotalTechGeek

compiler.js

@@ -4,7 +4,8 @@
 import {
   isSync,
   // Override is required for the compiler to operate as intended.
-  Override
+  Override,
+  Sync
 } from './constants.js'
 import declareSync from './utilities/declareSync.js'
 
@@ -97,6 +98,12 @@ function isDeepSync (method, engine) {
 
     const lower = method[func]
     if (!isSync(engine.methods[func])) return false
+
+    if (engine.methods[func].traverse === false) {
+      if (typeof engine.methods[func][Sync] === 'function' && engine.methods[func][Sync](method, { engine })) return true
+      return false
+    }
+
     return isDeepSync(lower, engine)
   }
 

constants.js

@@ -16,6 +16,7 @@ export const EfficientTop = Symbol.for('json_logic_efficientTop')
 export function isSync (item) {
   if (typeof item === 'function') return item[Sync] === true
   if (Array.isArray(item)) return item.every(isSync)
+  if (item && item.asyncMethod && !item.method) return false
   return true
 }
 

defaultMethods.js

@@ -88,7 +88,8 @@ const defaultMethods = {
   '<': ([a, b, c]) => (c === undefined ? a < b : a < b && b < c),
   preserve: {
     traverse: false,
-    method: declareSync((i) => i)
+    method: declareSync((i) => i, true),
+    [Sync]: () => true
   },
   if: {
     method: (input, context, above, engine) => {
@@ -399,6 +400,7 @@ const defaultMethods = {
   keys: (obj) => typeof obj === 'object' ? Object.keys(obj) : [],
   eachKey: {
     traverse: false,
+    [Sync]: (data, buildState) => isSyncDeep(Object.values(data[Object.keys(data)[0]]), buildState.engine, buildState),
     method: (object, context, above, engine) => {
       const result = Object.keys(object).reduce((accumulator, key) => {
         const item = object[key]

package.json

@@ -1,6 +1,6 @@
 {
   "name": "json-logic-engine",
-  "version": "2.1.2",
+  "version": "2.1.3",
   "description": "Construct complex rules with JSON & process them.",
   "main": "./dist/cjs/index.js",
   "module": "./dist/esm/index.js",