Skip to content

Conversation

@projekter
Copy link
Contributor

Fix #331
I also added equality definitions - if this is desired. However, it would be a breaking change - iszero and isone were simply not defined, so this is fine, but comparison with Zero went to the === fallback before and returned false. So I understand if you'd rather not have these comparisons.

@codecov
Copy link

codecov bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.36%. Comparing base (cc1be0e) to head (881c5dc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #332   +/-   ##
=======================================
  Coverage   90.35%   90.36%           
=======================================
  Files          22       22           
  Lines        2251     2253    +2     
=======================================
+ Hits         2034     2036    +2     
  Misses        217      217           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@blegat blegat merged commit eccbd5f into jump-dev:master Apr 1, 2025
10 of 11 checks passed
@blegat
Copy link
Member

blegat commented Apr 1, 2025

Failure on nightly shouldn't be related

@projekter projekter deleted the patch-1 branch April 1, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Is Zero zero?

3 participants