Skip to content

🐛 Wrong ListItem.EndTimeResume passed in dynamic nodes with addons utilizing infoTagVideo.setResumePoint #76

@OfficerKD637

Description

@OfficerKD637

Hey J!

Hope you've been well!

A lot of 3rd party video add-ons use infoTagVideo.setResumePoint since resumetime and totaltime in ListItem.setProperty() seem to be deprecated.

This is what shows up in the kodi logs:

"resumetime" in ListItem.setProperty() is deprecated and might be removed in future Kodi versions. Please use InfoTagVideo.setResumePoint().

"totaltime" in ListItem.setProperty() is deprecated and might be removed in future Kodi versions. Please use InfoTagVideo.setResumePoint().

If I create a "Continue Watching" widget (movies/episodes that have a resume point) that's pointed directly to the addon in the skin (using AF2 as an example here), the correct "Ends At" time is displayed.

But if I create a dynamic node in SV (with the same addon), the skin doesn't display the correct Ends At time, i.e. it considers the entire duration of the movie/episode and doesn't respect the resume point.

I also tested, if the same addon sets the resumetime and totaltime listitem properties, everything works.

info_tag = listitem.getVideoInfoTag()
info_tag.setResumePoint(float(progress))
				set_properties({'WatchedProgress': progress, 'ResumeTime': watched_status.get_resume_time_seconds(progress, duration), 'TotalTime': str(duration)})

But something like this won't work:

info_tag = listitem.getVideoInfoTag(True)
info_tag.setResumePoint(watched_status.get_resume_seconds(progress, duration))
set_properties({'WatchedProgress': progress})

Also just want to reiterate that this is only the case for dynamic nodes. Everything works perfectly if the widget is pointed directly to the addon.

Thank you!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions