AsyncCommnad not Cancelable

[carsten-riedel]

AsyncCommnad not Cancelable

appLifetime.ApplicationStopping will never stop even if called by an other background service or strg+c. (return 99 in my example)

I didn't found a solution right now, do you have some suggestion ?

        public class MyAsyncCommand : AsyncCommand<MyAsyncCommand.Settings>
        {
            private readonly DependencyService  dependencyService;
            private readonly IHostApplicationLifetime appLifetime;

            public MyAsyncCommand(DependencyService service, IHostApplicationLifetime appLifetime)
            {
                this.dependencyService = service;
                this.appLifetime = appLifetime;
            }

            public class Settings : CommandSettings
            {
                [Description("The shell commandline command")]
                [CommandArgument(0, "<CommandName>")]
                public string? CommandName { get; init; }
            }

            public override async Task<int> ExecuteAsync(CommandContext context, Settings settings)
            {
                dependencyService.PerformAction();
                try
                {
                    await Task.Delay(20000, appLifetime.ApplicationStopping);
                }
                catch (Exception ex)
                {
                    return 99;
                }
                return 1;
            }
        }

        public class DependencyService
        {
            public void PerformAction()
            {
                Console.WriteLine("Action performed.");
                AnsiConsole.Write(new Markup("[bold yellow]Hello[/] [red]World![/]"));
            }
        }
    }
    ```

[snargledorf]

@carsten-riedel I've created a similar library that doesn't have this issue if you want to check it out.

https://github.com/snargledorf/SpectreConsoleHost

@JuergenRB fyi, this issue is due to the fact that currently you are building your own copy of the IServiceProvider

Spectre.Console.Extensions.Hosting/src/Spectre.Console.Extensions.Hosting/Infrastructure/TypeRegistrar.cs

Line 17 in af08b3e

return new TypeResolver(_builder.BuildServiceProvider());

This service provider is independent from the service provider built by the host, which means the worker service is getting its IHostApplicationLifetime from the hosts service provider, while the commands are getting theirs from the service provider your TypeRegistrar built.

I solved this by implementing a ITypeRegistrar and ITypeResolver which have their own registry of type factories, but then fall back to an IServiceProvider which is sourced from the compiled host.

[carsten-riedel]

@snargledorf Thx for the info i managed to resolve this in a similar way, intention was to get a fix in the original source. But i haven't tested this for a while, so it seems that this is still required.