Would like to be able to do DIC on in-memory images

[sdh4]

I would like to be able to do DIC on in-memory images without having to write them to a file (they are not stored in a standard format). I'd be happy to implement the capability and submit a pull request.

Any suggestions on the approach?

One simple option would be to modify the Image2D class to handle both cases (filename, and Array2D, only one of which is valid at any given time.

Another option could be to make the Image2D class a superclass with subclasses for file input and array input.

A third option could be to make the existing Image2D class no longer "final" and make its methods virtual, so that a derived class could be externally defined. In this case the interface functions would need to become virtual methods (or thin layers over virtual methods) so that they will properly call the derived class's methods.

Thoughts?

[sdh4]

Implemented the first option mentioned above (Image2D class handles both cases) and submitted a pull request #2 . Feel free to reject if you don't like this approach.

[sdh4]

.... Happy to help out if you want me to test out changes or propose an abstract class interface. Anything terribly substantive might have to wait until the new year because of current time committments.

I've been using my fork (https://github.com/sdh4/ncorr_2D_cpp ) very successfully for the last six months. It has been working very well and we may be presenting at EM next year!