Improve worker robustness and repo discovery

- handle worker shutdown/channel failures and git wait status
- refactor filtering/parsing, add constants, and expand discovery tests
- add CI workflow, MSRV, and move docs into docs/

Author: jvm

.github/workflows/ci.yml

@@ -0,0 +1,19 @@
+name: CI
+
+on:
+  push:
+  pull_request:
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: dtolnay/rust-toolchain@master
+        with:
+          toolchain: 1.92.0
+          components: rustfmt, clippy
+      - run: cargo fmt --check
+      - run: cargo clippy --all-targets --all-features -- -D warnings
+      - run: cargo test
+      - run: cargo build --release

AGENTS.md

@@ -63,6 +63,14 @@ Required components:
 
 All code must meet these quality standards before commit:
 
+**When any code changes are made**, always run the full quality gate sequence before handing off:
+```sh
+cargo fmt
+cargo clippy --all-targets --all-features
+cargo test
+cargo build --release
+```
+
 ### 1. Formatting
 ```sh
 cargo fmt

Cargo.toml

@@ -2,6 +2,7 @@
 name = "git-dash"
 version = "0.2.0"
 edition = "2021"
+rust-version = "1.92.0"
 authors = ["Jose Mocito"]
 license = "MIT"
 description = "A fast TUI dashboard for discovering and managing multiple Git repositories"

docs/CLI.md

@@ -0,0 +1,77 @@
+# CLI Update Mode Specification
+
+This document specifies the proposed CLI update mode for git-dash. The goal is to
+use a single tool that behaves as a CLI when update flags are provided and falls
+back to the existing TUI when no update flags are present.
+
+## Mode Selection
+
+- TUI mode: no update flags provided (e.g., `git-dash` or `git-dash <path>`).
+- CLI mode: any update flag is present (`--pull` or `--push`).
+- A scan root path is still accepted in both modes (defaults to CWD).
+
+## CLI Usage
+
+```
+git-dash [OPTIONS] [PATH]
+
+Update options (CLI mode):
+  --pull            Pull updates (fast-forward only).
+  --push            Push updates.
+  --repo <name>     Target a single repo by folder name.
+  --dry-run         Show what would run without executing git commands.
+  --dirty <mode>    Handling for dirty repos: skip | allow | stash (default: skip).
+```
+
+Defaults:
+- If neither `--pull` nor `--push` is provided in CLI mode, perform both in order:
+  pull then push.
+- If `--repo` is not provided, all valid git repos under the scan root are used.
+- `--dirty=skip` is the default.
+- Implicit confirmation: presence of update flags means no interactive prompt.
+
+## Target Selection
+
+- Only valid git repos are included.
+- `--repo <name>` matches a top-level folder name exactly.
+- If the target repo is not found, exit with failure and a message.
+- Only one target repo can be selected at a time.
+
+## Operation Order
+
+- Combined operations always run in fixed order: pull then push.
+
+## Dirty Repo Handling
+
+- skip (default): do not run any update in that repo; report as skipped.
+- allow: run updates even if dirty; failures handled by git.
+- stash: stash uncommitted changes (including untracked), run updates, then pop.
+  If stash pop conflicts, mark as failed and leave stash intact.
+
+TUI behavior should follow the same rules when triggering pull/push for the
+selected repo.
+
+## Failure Handling
+
+- In all-repos mode, failures do not stop processing other repos.
+- A summary is printed at the end with counts for success, skipped, and failed.
+- The exit code is non-zero if any repo failed or was skipped.
+
+## Dry Run
+
+- Print the resolved repo list and the exact git commands that would run per repo.
+- Do not execute any git commands.
+
+## Output
+
+- Default: one line per repo with status (OK, SKIP, FAIL) and a short reason.
+- `--verbose` and `--quiet` are optional extensions if needed later.
+
+## Shared Logic
+
+- CLI and TUI should use the same internal update runner:
+  - repo filtering
+  - dirty handling
+  - remote validation
+  - pull/push execution
+  - result aggregation and summary formatting

SPEC.md docs/SPEC.mdSPEC.md renamed to docs/SPEC.md

@@ -264,14 +264,17 @@ Located in `tests/repo_discovery.rs`:
 - ✅ Comprehensive test suite (17 tests)
 - ✅ Homebrew tap support (personal tap: jvm/tap)
 
-### v0.2 (Planned)
-- Search and filter repositories
-- Sorting options (name/status/ahead-behind/last fetch)
-- Help screen with keybindings
-- Header stats (repo/dirty/ahead/behind counts)
-- Empty state handling
-- Colorized change summary display
-- Scroll hints for long lists
+### v0.2 (Completed)
+- ✅ Search and filter repositories
+- ✅ Sorting options (name/status/ahead-behind/last fetch)
+- ✅ Help screen with keybindings
+- ✅ Header stats (repo/dirty/ahead/behind counts)
+- ✅ Empty state handling
+- ✅ Colorized change summary display
+- ✅ Scroll hints for long lists
+
+### v0.3 (Planned)
+- TBD
 
 ---
 

src/app.rs

@@ -5,7 +5,7 @@ use std::time::Instant;
 use ratatui::widgets::TableState;
 
 use crate::discovery::RepoRef;
-use crate::status::RepoState;
+use crate::status::{parse_ahead_behind, RepoState, NO_REMOTE};
 use crate::worker::{Action, WorkerCmd};
 
 #[derive(Clone, Copy, PartialEq)]
@@ -17,11 +17,9 @@ pub enum SortOrder {
 }
 
 #[derive(Clone, Copy, PartialEq)]
-#[allow(dead_code)]
 pub enum StatusType {
     Success,
     Error,
-    Warning,
     Info,
 }
 
@@ -69,9 +67,12 @@ impl App {
     pub fn request_scan(&mut self) {
         self.loading = true;
         self.scan_progress = 0.0;
-        let _ = self.cmd_tx.send(WorkerCmd::Scan {
+        if let Err(err) = self.cmd_tx.send(WorkerCmd::Scan {
             root: self.root.clone(),
-        });
+        }) {
+            self.loading = false;
+            self.set_status(format!("Worker unavailable: {err}"));
+        }
     }
 
     pub fn request_refresh(&mut self) {
@@ -83,7 +84,9 @@ impl App {
                 git_dir: repo.git_dir.clone(),
             })
             .collect();
-        let _ = self.cmd_tx.send(WorkerCmd::Refresh { repos });
+        if let Err(err) = self.cmd_tx.send(WorkerCmd::Refresh { repos }) {
+            self.set_status(format!("Worker unavailable: {err}"));
+        }
     }
 
     pub fn request_confirm(&mut self, action: Action) {
@@ -94,7 +97,7 @@ impl App {
 
         // Validate that we have a remote before allowing push/pull
         if let Some(repo) = self.selected_repo() {
-            if repo.remote_url == "-" {
+            if repo.remote_url == NO_REMOTE {
                 self.set_status("No remote configured for this repository".to_string());
                 return;
             }
@@ -105,20 +108,25 @@ impl App {
 
     pub fn perform_action(&mut self, action: Action) {
         if let Some(repo) = self.selected_repo() {
-            let _ = self.cmd_tx.send(WorkerCmd::Action {
+            if let Err(err) = self.cmd_tx.send(WorkerCmd::Action {
                 path: repo.path.clone(),
                 action,
-            });
-            self.set_status("Running action...".to_string());
+            }) {
+                self.set_status(format!("Worker unavailable: {err}"));
+            } else {
+                self.set_status("Running action...".to_string());
+            }
         }
     }
 
     pub fn request_quit(&mut self) {
-        let _ = self.cmd_tx.send(WorkerCmd::Quit);
+        if let Err(err) = self.cmd_tx.send(WorkerCmd::Quit) {
+            self.set_status(format!("Worker unavailable: {err}"));
+        }
     }
 
     pub fn next(&mut self) {
-        let len = self.filtered_repos().len();
+        let len = self.filtered_indices().len();
         if len == 0 {
             return;
         }
@@ -130,7 +138,7 @@ impl App {
     }
 
     pub fn previous(&mut self) {
-        let len = self.filtered_repos().len();
+        let len = self.filtered_indices().len();
         if len == 0 {
             return;
         }
@@ -148,7 +156,7 @@ impl App {
     }
 
     pub fn page_down(&mut self) {
-        let len = self.filtered_repos().len();
+        let len = self.filtered_indices().len();
         if len == 0 {
             return;
         }
@@ -160,7 +168,7 @@ impl App {
     }
 
     pub fn page_up(&mut self) {
-        let len = self.filtered_repos().len();
+        let len = self.filtered_indices().len();
         if len == 0 {
             return;
         }
@@ -172,25 +180,24 @@ impl App {
     }
 
     pub fn jump_to_first(&mut self) {
-        if !self.filtered_repos().is_empty() {
+        if !self.filtered_indices().is_empty() {
             self.table_state.select(Some(0));
         }
     }
 
     pub fn jump_to_last(&mut self) {
-        let len = self.filtered_repos().len();
+        let len = self.filtered_indices().len();
         if len > 0 {
             self.table_state.select(Some(len - 1));
         }
     }
 
     pub fn selected_repo(&self) -> Option<&RepoState> {
-        let filtered = self.filtered_repos();
-        self.table_state.selected().and_then(|i| {
-            filtered
-                .get(i)
-                .and_then(|r| self.repos.iter().find(|repo| repo.path == r.path))
-        })
+        let indices = self.filtered_indices();
+        self.table_state
+            .selected()
+            .and_then(|i| indices.get(i).copied())
+            .and_then(|repo_idx| self.repos.get(repo_idx))
     }
 
     pub fn set_status(&mut self, status: String) {
@@ -261,17 +268,18 @@ impl App {
         self.help_visible = !self.help_visible;
     }
 
-    pub fn filtered_repos(&self) -> Vec<RepoState> {
+    pub fn filtered_indices(&self) -> Vec<usize> {
         if self.search_query.is_empty() {
-            self.repos.clone()
-        } else {
-            let query_lower = self.search_query.to_lowercase();
-            self.repos
-                .iter()
-                .filter(|repo| repo.name.to_lowercase().contains(&query_lower))
-                .cloned()
-                .collect()
+            return (0..self.repos.len()).collect();
         }
+
+        let query_lower = self.search_query.to_lowercase();
+        self.repos
+            .iter()
+            .enumerate()
+            .filter(|(_, repo)| repo.name.to_lowercase().contains(&query_lower))
+            .map(|(idx, _)| idx)
+            .collect()
     }
 
     pub fn enter_search_mode(&mut self) {
@@ -304,20 +312,8 @@ impl App {
 }
 
 fn has_ahead_or_behind(value: &str) -> bool {
-    if value == "-" {
-        return false;
+    match parse_ahead_behind(value) {
+        Some((ahead, behind)) => ahead > 0 || behind > 0,
+        None => false,
     }
-
-    let Some((ahead_part, behind_part)) = value.split_once('/') else {
-        return false;
-    };
-
-    let Ok(ahead) = ahead_part.trim_start_matches('+').parse::<u32>() else {
-        return false;
-    };
-    let Ok(behind) = behind_part.trim_start_matches('-').parse::<u32>() else {
-        return false;
-    };
-
-    ahead > 0 || behind > 0
 }

src/discovery.rs

@@ -9,7 +9,7 @@ pub struct RepoRef {
 
 pub fn discover_repos_with_progress<F>(root: &Path, mut on_progress: F) -> Vec<RepoRef>
 where
-    F: FnMut(usize, usize),
+    F: FnMut(usize, usize) -> bool,
 {
     let mut repos = Vec::new();
     let mut stack = vec![root.to_path_buf()];
@@ -50,8 +50,8 @@ where
             stack.push(subdir);
         }
 
-        if visited.is_multiple_of(20) || stack.is_empty() {
-            on_progress(visited, stack.len());
+        if (visited.is_multiple_of(20) || stack.is_empty()) && !on_progress(visited, stack.len()) {
+            return repos;
         }
     }