Skip to content

tooling: The semver labels on PRs does not analyse kubebuilder validations #440

@pierreprinetti

Description

@pierreprinetti

Problem description

The mechanism we use to track backwards-compatibility (the workflow that applies the semver labels to PRs) only checks that the Go code is backwards-compatible.

However, in this repository the API is also very much defined in comments: that's where Kubebuilder sources its instructions for validation. If in the validation of a number we stopped accepting anything greater then 4, then this would represent a backwards-incompatible change but the label would say semver:patch.

Something similar happened with the PR that added mutability to Subnet: it was tagged as semver:patch even though it definitely expanded the API of our controller.

Down the line, the semver check should also incorporate a check of the validation... once a tool for that exists.

ORC version

main

Additional information

No response

Relevant log output

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions