Skip to content

Commit c078893

Browse files
authored
Merge pull request #61 from dweomer/fix-toleration
fix uninitialized toleration
2 parents 2b44dc0 + ca65177 commit c078893

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

pkg/helm/controller.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ import (
2121
rbac "k8s.io/api/rbac/v1"
2222
"k8s.io/apimachinery/pkg/api/errors"
2323
meta "k8s.io/apimachinery/pkg/apis/meta/v1"
24-
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2524
"k8s.io/apimachinery/pkg/runtime"
2625
"k8s.io/apimachinery/pkg/types"
2726
"k8s.io/apimachinery/pkg/util/intstr"
@@ -54,7 +53,7 @@ func Register(ctx context.Context, apply apply.Apply,
5453
apply = apply.WithSetID(Name).
5554
WithCacheTypes(helms, jobs, crbs, sas, cm).
5655
WithStrictCaching().WithPatcher(batch.SchemeGroupVersion.WithKind("Job"), func(namespace, name string, pt types.PatchType, data []byte) (runtime.Object, error) {
57-
err := jobs.Delete(namespace, name, &metav1.DeleteOptions{})
56+
err := jobs.Delete(namespace, name, &meta.DeleteOptions{})
5857
if err == nil {
5958
return nil, fmt.Errorf("replace job")
6059
}
@@ -238,7 +237,7 @@ func job(chart *helmv1.HelmChart) (*batch.Job, *core.ConfigMap, *core.ConfigMap)
238237
},
239238
{
240239
Key: "node.cloudprovider.kubernetes.io/uninitialized",
241-
Operator: "=",
240+
Operator: core.TolerationOpEqual,
242241
Value: "true",
243242
Effect: "NoSchedule",
244243
},

0 commit comments

Comments
 (0)