Skip to content

Escape quotes in identifiers #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Escape quotes in identifiers #771

wants to merge 1 commit into from

Conversation

@alexandermalyga
Copy link
Contributor

Fix #768

@alexandermalyga alexandermalyga requested a review from a team as a code owner November 24, 2023 13:03
williambdean
williambdean reviewed Nov 27, 2023
View reviewed changes
pypika/tests/test_terms.py
Comment on lines +80 to +82
customers = Table('customers"')
customer_id = getattr(customers, '"id')
email = getattr(customers, 'email"').as_('customer_email"')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happens with single quotes inside double quotes?

@jereze jereze mentioned this pull request Aug 2, 2024
Merged
AzisK pushed a commit that referenced this pull request Oct 25, 2025
@jereze @alexandermalyga
Additional Changes to "Escape quotes in identifiers (#771)" (#811)
e71ed34 
* Escape quotes in identifiers

* Add more tests to confirm that escaping quotes in identifiers works and remove FIXME placeholders

---------

Co-authored-by: Alexander Malyga <alexander@malyga.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@williambdean williambdean williambdean left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Identifier quote escaping

2 participants

@alexandermalyga @williambdean