Skip to content
This repository was archived by the owner on Jul 7, 2023. It is now read-only.
This repository was archived by the owner on Jul 7, 2023. It is now read-only.

need a patch otherwise won't work with deadbeef>=v0.5.5 #14

@ipchu

Description

@ipchu

Probably the same issue as in #8

I recently installed deadbeef v0.6.1 and googled a bit about MPRIS plugin.
Then I ran into an article http://ihacklog.com/post/perfect-lyric-displaying-with-deadbeef-0-5-6-deadbeef-mpris-plugin-and-osd-lyrics.html which presented a patch to this so-called "glib-dbus threadsafe" issue.

I thought that the patch must have already been applied to this github repository, if not I still wouldn't have a chance because I wasn't able to rewrite all the codes myself from "glib-dbus" to "GDBus lib".

Apparently I was wrong. On two things:

  1. the patch ( http://git.ihacklog.com/repo/DeaDBeeF-MPRIS-plugin.git/commit/?id=2f29d50d68e1c4a1be8e4e8d694817991edb71b8 ) wasn't applied here yet!!!
  2. the original code did use GDBus lib from the very beginning. "glib-dbus" was the same thing as GDBus (which is a part of glib/gio). There is an obsolete and thread-unsafe lib called dbus-glib (as a part of dbus lib), but it was never used here. BTW the real issue in mpris.c was that one should use GLib mutual exclusive thread instead of GLib mainloop.

Finally, I downloaded the master branch snapshot and manually modified mpris.c.
After adding -I/opt/deadbeef/include to Makefile.am
./autogen.sh
./configure --prefix=/opt/deadbeef
make
sudo make install
deadbeef &

Then it worked perfectly.

OS: ubuntu 13.10 Saucy Salamander with kubuntu-desktop installed
kernel Linux 3.11.0-19-generic x86_64
gcc (Ubuntu/Linaro 4.8.1-10ubuntu9) 4.8.1
glib 2.38.1

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions