Skip to content

Conversation

@meld-cp
Copy link

@meld-cp meld-cp commented Jul 26, 2025

  • Right align Size, Files and Dirs columns
  • Use toLocaleString() for Files and Dirs values
image
  • Added locale to preferences to format dates and numbers (requires PR 4741, fixes 4734)
image
  • Fixed byte representation not honored for snapshot list (fixes: 4733)
  • Added sorting to DirectoryItems Name column (fixes: 4684)

meld-cp added 2 commits July 26, 2025 23:34
- Right align Size, Files and Dirs columns
- Use toLocaleString() for Files and Dirs values
@meld-cp meld-cp changed the title Formatted Size, Files, and Dirs columns Formatting changes Jul 26, 2025
@meld-cp meld-cp marked this pull request as draft July 26, 2025 15:01
@meld-cp meld-cp marked this pull request as ready for review July 26, 2025 16:29
@meld-cp meld-cp changed the title Formatting changes Column formatting & sorting changes Jul 27, 2025
@meld-cp meld-cp changed the title Column formatting & sorting changes feat(ui): column formatting & sorting changes Aug 5, 2025
@tessus
Copy link

tessus commented Oct 4, 2025

@meld-cp the pipeline is failing with:


Run npm run prettier:check

> htmlui@0.1.0 prettier:check
> prettier --check .

Checking formatting...
[warn] src/components/DirectoryItems.jsx
[warn] src/contexts/UIPreferencesContext.tsx
[warn] src/css/App.css
[warn] src/pages/SnapshotHistory.jsx
[warn] src/pages/Snapshots.jsx
[warn] src/utils/formatutils.js
[warn] Code style issues found in 6 files. Run Prettier with --write to fix.
Error: Process completed with exit code 1.

@tessus
Copy link

tessus commented Oct 4, 2025

@jkowalski is the above issue the only blocker for merging?

@meld-cp
Copy link
Author

meld-cp commented Oct 4, 2025

Thanks @tessus, I'm traveling, but can revisit this in a few days

@tessus
Copy link

tessus commented Oct 4, 2025

@meld-cp no rush, have fun travelling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants