fix: Optimize tests and CI/CD by using smaller docker images #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Junkern
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unifies the image usage in (mostly) tests.
I noticed this, because I could not run some tests locally. The
cruximage is not maintained anymore since over 2 years, and thus, has noarm64image (I am running an M1 mac).In addition, the
busybox:1.35.0is almost 60 MB smaller than thenginx:latest, so that will hopefully also account for some time reduction in CI/CD.Things I noticed while debugging:
busyboxdoes not suffice, because it instantly exists. Then test fail, because they can't cleanupbusyboxdoes not work here, either