PersistentHashMap.iterator bug: null key and value in entries

[jordanlewis]

Occasionally, PersistentHashMap's entry iterator will return an entry whose key and value are both null.

Running my test case in the debugger, I can see that the map's hasNull value is set to false. Additionally, my code never assocs a null key or value into the map. Running the same test case with PersistentHashMap.iterator2 (the original recursive Seq implementation from Clojure) does not produce entries with null keys or values.

Unfortunately, I don't have a minimal test case at this time. I'm starting this issue as a placeholder, in case you have or someone else has a good idea of what's going wrong.

Thoughts?

[krukow]

Ok, thanks for the report. Is it possible for you give me some info on how to reproduce? I thought I had tested the iterator pretty well.

[jordanlewis]

I don't have a minimal test case yet.

However, I also discovered that there's another bug, this one actually present in mainline Clojure 1.3. It seems to me that it's more than likely that the bug I discovered is actually a manifestation of the bug in Clojure, that was fixed in http://dev.clojure.org/jira/browse/CLJ-829.

I'm uploading a pull request that merges in the fix for the above.

[PerMildner]

Has this not been fixed already, with #5?