fix: update jsonpath-plus to 10.3.0 across CRUD web apps (Security v1.11) #784
+210,219
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/frontend (kubeflow/kubeflow#6287) Bumps [shelljs](https://github.com/shelljs/shelljs) from 0.8.4 to 0.8.5. - [Release notes](https://github.com/shelljs/shelljs/releases) - [Changelog](https://github.com/shelljs/shelljs/blob/master/CHANGELOG.md) - [Commits](shelljs/shelljs@v0.8.4...v0.8.5) --- updated-dependencies: - dependency-name: shelljs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…-apps/jupyter/frontend (kubeflow/kubeflow#6444) Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.23 to 3.3.2. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](ai/nanoid@3.1.23...3.3.2) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…pps/volumes/frontend (kubeflow/kubeflow#6449) Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](caolan/async@v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Benjamin Tan <benjamin.tan@tech.jago.com>
Fix kubeflow/kubeflow#6366 Migrating to Kubebuilder v3 leads to the following changes: - Add .dockerignore file. - Upgrade Go version from v1.15 to v1.17. - Adapt Makefile. - Add image (build + push) target to makefile. - Upgrade EnvTest to use K8s v1.22. - Update PROJECT template. - Migrate CRD apiVersion from v1beta to v1. - Add livenessProbe and readinessProbe to controller manager. - Upgrade controller-runtime from v0.2.0 to v0.11.0. Other changes: - Build image using public.ecr.aws registry instead of gcr.io. - Update README.md documentation. - Update 3rd party licences. - Fix notebook.spec description. - Add 3 sample notebooks (v1, v1alpha1 and v1beta1). Signed-off-by: Samuel Veloso <svelosol@redhat.com>
* Cherry-pick latest commits to the 1.5-branch (kubeflow/kubeflow#6354) * Fix(manifests): Upgrade rbac.authorization.k8s.io from v1beta1 to v1 (kubeflow/kubeflow#6261) * proposal: Extend Notebook Controller to expose idleness for Jupyter (kubeflow/kubeflow#6295) * proposal: Extend Notebook Controller to expose idleness for Jupyter (kubeflow/kubeflow#6270) Provide a design doc as a proposal for extending Notebook Controller to expose idleness for Jupyter. Our proposal is in markdown format and follows the guidelines of the kubeflow/components/proposal/README.md guide. You can view the #6270 issue in the following link: kubeflow/kubeflow#6270 Signed-off-by: Athanasios Markou <athamark@arrikto.com> * review: change the title of the proposal Change the title of the proposal to only include the proposed new feature. The new title of the proposal will now be "Expose Idleness Information for Jupyter Notebooks". * review: rename the proposal markdown file We want to give a more specific name to the markdown which contains the proposal. Since this proposal emphasizes on a feature regarding the Jupyter Notebooks, the new name will be: 20220121-jupyter-notebook-idleness.md * Synchronize jupyter-web-application role with clusterrole (kubeflow/kubeflow#6241) * Update role.yaml * Update role.yaml * Update cluster-role.yaml * Kubeflow Roadmap update - with 1.5 details (kubeflow/kubeflow#6266) * Kubeflow Roadmap update - with 1.5 details These proposed changes include: identifying that 1.4.1 has been delivered, provides themes for 1.5 and provides details of major features in 1.5 by working group. This is an initial proposal that needs review by the working group leads. * correct formatting in KFP features Moved KFP features under KFP Control Flow doc * updating KFP section updating KFP references with updates from KFP team * Updated the 1.5 release date to March updated the 1.5 release date to March * Update ROADMAP.md change Hyperparameter leader election to Katib leader election Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * Update ROADMAP.md improve description and details of feature for metrics collector Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * Update Katib description for Early stopping in 1.5 updating with Andrey's suggestion (but without the world proper). * Validation for Early Stopping algorithm settings helps users to proper reduce model overfitting Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * notebooks: Extend Notebook Controller to expose idleness for Jupyter (kubeflow/kubeflow#6297) * notebooks: Update image's tag in make Modify Makefile to update properly the TAG based on the git TAG. Signed-off-by: Athanasios Markou <athamark@arrikto.com> Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Expose last-activity Extend the notebook-controller to: * cull idle Notebook Servers based on their new `last-activity` annotation * expose the last activity of each Notebook Server as an annotation on the metadata of the corresponding CR object Modify notebook_controller.go to: * update the Last Activity of each Notebook Server that has a Running pod * delete the Last Activity Annotation for every Notebook Server that does not have a Running pod Extend culler.go to: * perform culling based on the new `last-activity` annotation and not based on the `/api/status` endpoint. * update the last activity of a Notebook Server, based on the kernels' execution states. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Athanasios Markou <athamark@arrikto.com> * notebooks: Introduce a DEV env var We introduce a DEV ENV var to allow admins develop and test on their local machine their custom Notebook Controller. We provide information and instructions inside the components/notebook-controller/README.md. Signed-off-by: Athanasios Markou <athamark@arrikto.com> Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Add unit tests for last-activity * Introduce new tests for allKernelsAreIdle() * Extend the tests for NotebookIsIdle() and for NotebookNeedsCulling(). Signed-off-by: Athanasios Markou <athamark@arrikto.com> Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * review: UpdateNotebookLastActivityAnnotation() Ensure that UpdateNotebookLastActivityAnnotation() does not return "true". This function should not return any value. Signed-off-by: Athanasios Markou <athamark@arrikto.com> * jwa: Rework the Storage API of the web app (kubeflow/kubeflow#6321) * wa(back): Add helper for deserializing JSON obj In some cases we might need to construct Python k8s lib objects from the JSONs that are provided by clients. I.e. the UI will be sending a PVC object in json format, so the backend will need to create the corresponding client.V1PersistentVolumeClaim object and submit it. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * wa(back): Serialization helper Add helper function for converting a k8s-client object into a dict that can be sent as an HTTP response. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * wa(back): Add dry run to Notebooks and PVCs The backend will need to be able to create objects with dry-run, in order to ensure they are valid. The backend will need to check that both the Notebook and the PVCs can be created beforehand. This way we avoid the scenario where we create PVCs but the Notebook fails to be created, and the PVCs are never garbage collected. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * wa(back): Update kubernetes to 0.17 In order to support dry-run we must use the 0.17 version of the Python k8s client. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * wa(back): Extend api module to patch pvcs The backend will need to be able to PATCH PVCs in order to set the ownerReference to the Notebook that mounts the PVCs. Ref: arrikto/dev/issues/386#issuecomment-856700392 Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * jwa(back): Work with new Volumes API The backend API should not add any more layers of abstractions on top of the K8s API. The backend should expect the client/UI to be sending the entire PVC spec of a new PVC. Refs: arrikto/dev/issues/386 Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * jwa(back): Add unittests for new volumes API Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * jwa(back): Extend the PVC info returned We want to show both the access mode and size of the existing PVCs, when a user clicks on the dropdown to select which PVC to mount. The backend will need to provide this information to the frontend. We don't want to send the K8s list of PVCs since this will result in a lot of unnecessary data to be sent. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * jwa(front): Add proxy config for Rok When developing the Rok flavor locally we will need to be able to open the Rok chooser. This can be done by using Angular/webpack proxy to bring the exposed rok service and the app under the same domain. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * jwa(front): Remove card from form The form of the app should not be a big card, but a normal form. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * jwa(front): Install AceModule for yaml editing Install AceModule to allow users to edit yamls of objects. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * wa(front): Change the styling of form sections Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * jwa(front): Create common volume components Component for: * New PVC and configuring its spec * Attaching an existing PVC in a Notebook Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * jwa(front): Update Rok form for new Volume API Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * jwa(front): Mark inputs as dirty when restoring Lab When the UI autofills the form with values from a JupyterLab snapshot then it should mark the touched fields as dirty. This way if a field has errors the UI will make that input red. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * jwa: Update ConfigMap in manifests Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * jwa(front): Fix format errors Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * profiles: Update the permissions for notebook idleness (kubeflow/kubeflow#6335) Extend the Profiles Controller to give permissions to Notebooks controller for making GET requests to notebook's /api/kernels endpoint. Refs https://github.com/kubeflow/kubeflow/blob/master/components/proposals/20220121-jupyter-notebook-idleness.md Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Graceful handling of events (kubeflow/kubeflow#6338) * notebooks: Handle events gracefully The controller is not exiting the reconciliation loop after it has re-emitted a Pod/STS Event as a Notebook Event. This results in the controller to later on try and GET a Notebook with the name of the Event that triggered the reconciliation loop. The controller should exit the reconciliation function once it has emitted the event. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Don't reconcile on deleted events We don't want to trigger the reconciliation function when an event gets deleted. If a Notebook would be deleted then the underlying events would be deleted as well, which results in the reconcile function to get triggered and try to GET Events and Notebooks with the name of the deleted event. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Fix endless restarts (kubeflow/kubeflow#6341) * notebooks: Update notebook if timestamp changed We don't want to be updating the spec of the notebook if the timestamp hasn't changed, since this will lead to constant updates and reconciliation loops. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Use a deep-copy of the notebook spec The controller should use a deep-copy of the notebook spec when calculating the spec for the StatefulSet. If not then we could update the notebook object without wanting it, since the spec could have been changed when calculating the STS spec. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Add prefix env var only if missing The controller should be setting OR updating the NB_PREFIX env var. Previously it would always blindly append it to the spec, which could result in double entries for the same env var. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * releasing: Update tags for v1.5.0-rc.1 (kubeflow/kubeflow#6343) Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * fix error comparison between pointer and pointer in "CopyStatefulSetFields" (kubeflow/kubeflow#6195) error comparison between pointer and pointer in "CopyStatefulSetFields" * [bugfix]: update unsupported links to latest pages (kubeflow/kubeflow#6192) * centraldashboard: Add KServe overlay (kubeflow/kubeflow#6383) Configure the dashboard to use the KServe app instead of the KFServing 0.6.1 one. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Don't reconcile on Events deletion (kubeflow/kubeflow#6391) The controller should not trigger the reconcile loop when an Event is deleted. Previously the controller would run the reconciliation loop on any event deletion. This commit updates it to not run the loop for ANY event. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * releasing: Create v1.5.0-rc.2 images (kubeflow/kubeflow#6394) Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * fixed typo * fixed typo * changed remove rc2 Co-authored-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> Co-authored-by: mofanke <54242816+mofanke@users.noreply.github.com> Co-authored-by: Jaeyeon Kim <anencore94@gmail.com>
) * Migrate tensorboard-controller to Kubebuilder v3 * Fix paths inside Docker context * Remove test dependency from docker-build * Switch to kustomize 3.2.0, fix image tag * Fix namePrefix * Rename deployments, remove namespaces * Add runAsUser * Make tensorboard image and istio gateway configurable
We want to extend JWA to have a column for showing the `Last activity` of a Notebook CR. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
…#6555) * build: Update components makefiles for building We'll create a top-level Makefile under components/ dir that has the following rules: * build-all: To build all images locally * push-all: * We can use a specific REGISTRY and retag the images * Push all the images This top-level Makefile will run the sub-Makefiles that every component has for building and pushing the images. We modified every sub-Makefile as follows: * We don't use a registry in images by default * Removed unused rules and vars * Use the --dirty flag of git describe in TAG --dirty[=<mark>] Describe the working tree. It means describe HEAD and appends <mark> (-dirty by default) if the working tree is dirty. Signed-off-by: Apotolos Gerakaris <apoger@arrikto.com> * build: Create makefiles for notebook servers The common starting point of building the notebook-server images are the following 4 *base* images: - base - codeserver - jupyter - rstudio All other server images need to build on top of them. We'll dynamically pass the base images in every Dockerfile by using an ARG IMG. We can set the value of this ARG during docker build with the --build-arg CLI argument. This way we build both the base images with a tag locally, and then we pass that image as arg via the Makefile and build the rest So we modified our building procedure as follows: 1. Build the base image since everything starts from there 2. Pass the base image as an ARG in the Dockerfiles of jupyter, codeserver, rstudio images and build on top 3. Pass the base images in all other server images and build on top For that we will: 1. Create a Makefile for each of the notebook servers, in each folder a. Each makefile will be responsible for building the bases and use args for passing them on 2. Use the central Makefile to call each Makefile from above Signed-off-by: Apotolos Gerakaris <apoger@arrikto.com> * cherry-pick: Notebook server upstream fixes Relevant upstream PR: https://github.com/kubeflow/kubeflow/pull/6466/files Signed-off-by: Apotolos Gerakaris <apoger@arrikto.com> * build: Fix Makefiles - Remove build-gcp and build-gcr rules as we don't use them anywhere in the project - Fix code conficts Signed-off-by: Apotolos Gerakaris <apoger@arrikto.com> * build: Fix Dockerfiles for notbook-server images We remove the previous logic of using already built images as bases. The users must use only the Makefiles to pass the appropriate BASE_IMG and build the images correctly. Thus, we have Makefiles everywhere that: - Can build any base image - If an image requires another notebook base, then we first build that one using its makefile, and then use it as docker ARG for building the next one Signed-off-by: Apotolos Gerakaris <apoger@arrikto.com> * build: Fix notebook-controller Makefile Removed a misplaced "|" char that breaks the Makefile Signed-off-by: Apotolos Gerakaris <apoger@arrikto.com> * build: Update GH action workflows * Update workflow for notebook-server images: - Add a step for building all images by using the central-Makefile under components/example-notebook-servers/ dir. - Add a step for pushing all images by using the central-Makefile under components/example-notebook-servers/ dir. * Update workflow for all Kubeflow images: - Add a step for building & pushing all images by using the top-level Makefile under components/ dir. Signed-off-by: Apotolos Gerakaris <apoger@arrikto.com> * build: Remove completely ECR references from images Replace everywhere the "public.ecr.aws/j1r0q0g6/notebooks/notebook-servers" prefix with "kubeflownotebookswg" Signed-off-by: Apotolos Gerakaris <apoger@arrikto.com> * build: Fix GH actions for Kubeflow components Fix GH actions to use the updated make rules when building the Kubeflow component images. Remove the "docker.io" prefix when building with GH action workflows Signed-off-by: Apotolos Gerakaris <apoger@arrikto.com>
* build: Migrate tslint to eslint * crud webapps - migrate tslint to eslint * fix npm versions * fix npm deps
* fix lint errors * fix lint * Update package-lock.json * Update package-lock.json * Add workflow for frontend lint
…w#6625) Fix image group one and two not showing in JWA's New notebook form, even when the avaialable config provides value for them. Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com> Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* Fix #6528: Mirroring Pod conditions to Notebook * Added missing fields which are part of PodConditions into NotebookConditions * Added suggested changes
* Fix #6056: Update Notebook status properly Signed-off-by: Apostolos Gerakaris apoger@arrikto.com * Added suggested code changes Signed-off-by: Apostolos Gerakaris apoger@arrikto.com * notebook-controller: Add unit tests *Introduce basic unit tests for "createNotebookStatus" function *Add GH action for unit tests Signed-off-by: Apostolos Gerakaris apoger@arrikto.com * Fix PodCoditionsMirroringToNotebook & Unit-tests We encountered an error during testing. It seems that the pod.status.conditions.condition.LastProbeTime remains always null and so the controller ends up applying a Notebook CR instance with null condition values. Relevant Issues: *kubernetes/kubernetes#109958 *kubernetes/kubernetes#79402 *kubernetes/kubernetes#14393 Fix: Check if the Pod's condition.LastProbeTime and condition.LastTransitionTime timestamp fields are null. If so, initialize them so we dont end up applying a Notebook instance with null condition values. Other changes: *Fix basic unit tests *Introduced a unit test for the case where Notebook's Pod is unschedulable Signed-off-by: Apostolos Gerakaris apoger@arrikto.com Signed-off-by: Apostolos Gerakaris apoger@arrikto.com
The notebook controller writes the last-activity annotation before culling the Notebook, however, doesn't remove this annotation before start. This causes the Notebook to be culled again before is has a chance to start. Fix: * calculate correctly the podFound variable and ensure its value its true only if the Pod is actually found. This way the culling annotation will be removed when there is no Pod. Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com> Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
Docker is dead and superseeded by OCI on all common Platforms
…ps/jupyter/frontend (kubeflow/kubeflow#6654) Bumps [jose](https://github.com/panva/jose) from 2.0.5 to 2.0.6. - [Release notes](https://github.com/panva/jose/releases) - [Changelog](https://github.com/panva/jose/blob/v2.0.6/CHANGELOG.md) - [Commits](panva/jose@v2.0.5...v2.0.6) --- updated-dependencies: - dependency-name: jose dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…o notebooks-v1 branch (kubeflow#603) migrate the files below to kubeflow/notebooks-v1 branch - tb_controller_multi_arch_test.yaml - tb_controller_integration_test.yaml Signed-off-by: Ilya Shavkonov <ishavkon@redhat.com>
Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
* feat: migrate VWA workflows clean Signed-off-by: Hen Schwartz (EXT-Nokia) <hen.schwartz.ext@nokia.com> * feat: migrate VWA workflows clean - add cypress 14.1.0 tough-cookie 4.1.3 Signed-off-by: henschwartz <hschwart@redhat.com> --------- Signed-off-by: Hen Schwartz (EXT-Nokia) <hen.schwartz.ext@nokia.com> Signed-off-by: henschwartz <hschwart@redhat.com>
Signed-off-by: Yehudit Kerido <yehudit1987@gmail.com>
…b Action to kubeflow/notebooks - notebooks-v1 branch (kubeflow#649) Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com> Co-authored-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>
…ation (kubeflow#662) This commit implements issue kubeflow#657 by adding automation for updating image tags in Kubernetes manifests during the release process. Changes: - Add releasing/update-manifests-images.py script that updates image tags in kustomization.yaml files for all 6 Notebooks v1 components - Add releasing/README.md with comprehensive release process documentation The script uses the correct ghcr.io image paths from the existing kustomization files and only updates the newTag field, preserving the original image registry paths. Components updated by the script: - Jupyter Web App (ghcr.io/kubeflow/notebooks/jupyter-web-app) - Tensorboards Web App (ghcr.io/kubeflow/kubeflow/tensorboards-web-app) - Volumes Web App (ghcr.io/kubeflow/kubeflow/volumes-web-app) - Notebook Controller (ghcr.io/kubeflow/kubeflow/notebook-controller) - PVC Viewer Controller (ghcr.io/kubeflow/kubeflow/pvcviewer-controller) - Tensorboard Controller (ghcr.io/kubeflow/kubeflow/tensorboard-controller) Closes kubeflow#657 Signed-off-by: Asaad Balum <asaad.balum@gmail.com>
Signed-off-by: Yehudit Kerido <yehudit1987@gmail.com>
Signed-off-by: Yehudit Kerido <yehudit1987@gmail.com>
kubeflow#668) Signed-off-by: Abdallah Samara (EXT-Nokia) <abdallah.samara.ext@nokia.com> Co-authored-by: Abdallah Samara (EXT-Nokia) <abdallah.samara.ext@nokia.com>
Signed-off-by: noa limoy <nlimoy@redhat.com>
Signed-off-by: noa limoy <nlimoy@redhat.com>
Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com> Co-authored-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>
- Delete common component (OWNERS, go.mod, reconcilehelper/) - Copy reconcilehelper/util.go to both notebook-controller and tensorboard-controller - Update imports in both controllers to use local reconcilehelper - Remove common dependency from go.mod files - Update Dockerfiles to remove common component references Signed-off-by: Yehudit Kerido <ykerido@ykerido-thinkpadp1gen7.raanaii.csb> Co-authored-by: Yehudit Kerido <ykerido@ykerido-thinkpadp1gen7.raanaii.csb>
Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>
…_PLAN.md Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>
Signed-off-by: Liav Weiss <74174727+liavweiss@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
utruong309
changed the title
Signed-off-by: Uyen Truong <uyenthutruong09@gmail.com>
github-project-automation
bot
moved this from Needs Triage
to Done
in Kubeflow Notebooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
jsonpath-plusdependency to version 10.3.0 across allCRUD Web App frontends (common, jupyter, tensorboards, volumes) as part of the
Security & Maintenance Hardening work for the v1.11 release.
This addresses:
These vulnerabilities were identified in the recent security scan and are
tracked under:
related: #783
parent: #720
Summary of Changes
jsonpath-plusversion to 10.3.0 in:components/crud-web-apps/common/frontend/kubeflow-common-libcomponents/crud-web-apps/jupyter/frontendcomponents/crud-web-apps/tensorboards/frontendcomponents/crud-web-apps/volumes/frontendpackage-lock.jsonfilesBuild & Verification Notes
npm run lint,npm run test,npm run build).vulnerability-planbranch:kubeflowasset importskubeflowmodule pathsjsonpath-plusupdate.No additional functionality changes introduced.