Skip to content

✨ Call GenerateUpgradePlanRequest Runtime Extension #12903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 31, 2025
Merged

✨ Call GenerateUpgradePlanRequest Runtime Extension #12903

merged 4 commits into from
Oct 31, 2025
+182 −9

Conversation

@sivchari
Copy link
Member

What this PR does / why we need it:

Part of #12720

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/area clusterclass

@k8s-ci-robot k8s-ci-robot added area/clusterclass Issues or PRs related to clusterclass cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 28, 2025
@sbueringer sbueringer mentioned this pull request Oct 28, 2025
Open
28 tasks
@sivchari
Copy link
Member Author

/cc @sbueringer @fabriziopandini

sbueringer
sbueringer reviewed Oct 29, 2025
View reviewed changes
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 29, 2025
@fabriziopandini fabriziopandini added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 29, 2025
@fabriziopandini
Copy link
Member

Nice! lgtm from my side pending addressing the linter issue

@sivchari
Copy link
Member Author

Thanks! I fixed lint error.

sbueringer
sbueringer reviewed Oct 30, 2025
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx just a few minor findings

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 30, 2025
@sivchari sivchari force-pushed the call-generate-upgrade-plan branch from 5d78805 to e223997 Compare October 30, 2025 11:45
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 30, 2025
@sbueringer
Copy link
Member

Thx. Looks good, just needs a unit test fix (TestReconcileMachinePhases is an independent flake)

Let's merge this PR after #12891 is merged. I really want to avoid rebase of #12891.

But you can already start working on the next PR on top of this PR if you want.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 30, 2025
@sbueringer
Copy link
Member

sbueringer commented Oct 31, 2025 •
edited
Loading

@sivchari #12891 will merge in a bit. Please rebase then and fix the unit test then this should be good to go :)

@sivchari
call GenerateUpgradePlanRequest Runtime Extension
89e1c19 
Signed-off-by: sivchari <shibuuuu5@gmail.com>
@sivchari
add unit test for UpgradePlan extension
b7dc9f3 
Signed-off-by: sivchari <shibuuuu5@gmail.com>
@sivchari
fix lint error
b54722f 
Signed-off-by: sivchari <shibuuuu5@gmail.com>
@sivchari sivchari force-pushed the call-generate-upgrade-plan branch from e223997 to 5ef3f59 Compare October 31, 2025 11:26
@sivchari
Copy link
Member Author

@sbueringer I've rebased this, PTAL.

@sivchari
fix review findings
afaecc6 
Signed-off-by: sivchari <shibuuuu5@gmail.com>
@sivchari sivchari force-pushed the call-generate-upgrade-plan branch from 5ef3f59 to afaecc6 Compare October 31, 2025 11:46
@sbueringer
Copy link
Member

Thank you very much!!

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8975efebda4e08e7ae3bd726933717ed4e8d6e8b

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2025
@k8s-ci-robot k8s-ci-robot merged commit 1c66738 into kubernetes-sigs:main Oct 31, 2025
18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbueringer sbueringer sbueringer left review comments

@richardcase richardcase Awaiting requested review from richardcase

@vincepri vincepri Awaiting requested review from vincepri

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

Assignees

@sbueringer sbueringer

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterclass Issues or PRs related to clusterclass cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

v1.12

Development

Successfully merging this pull request may close these issues.

4 participants

@sivchari @fabriziopandini @sbueringer @k8s-ci-robot