generated from kubernetes/kubernetes-template-project
-
Couldn't load subscription status.
- Fork 185
Open
Labels
gie-area/releaseCategorizes an issue or PR as relevant to GIE releases.Categorizes an issue or PR as relevant to GIE releases.good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.triage/acceptedIndicates an issue or PR is ready to be actively worked on.Indicates an issue or PR is ready to be actively worked on.
Milestone
Description
The hack/release-quickstart.sh script contains the following bugs:
- Release: Updates EPP tag sed for quickstart script #1035 generalized the sed command to manage the tag for the EPP image. However, the previous sed should be used when
RCis set and the current logic should be used whenRCis unset. - A
lora-syncertagged image is created when a release is cut. Still, the vLLM CPU, GPU and Sim manifests are not updated to set the image tag like it does for the EPP image tag in the same manifests. Here's an example of the e-extension/blob/v0.4.0/config/manifests/vllm/gpu-deployment.yaml#L158 that still uses the main tag. - The
VERSIONenv var insite-src/guides/index.mdis not updated. - All the references to
mainresources should use the tagged branch instead, i.e.kubectl apply -f https://github.com/kubernetes-sigs/gateway-api-inference-extension/raw/main/config/manifests/vllm/gpu-deployment.yamlshould bekubectl apply -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/$VERSION/config/manifests/vllm/gpu-deployment.yaml. This ensures the entire quickstart guide algins with a release.
Metadata
Metadata
Assignees
Labels
gie-area/releaseCategorizes an issue or PR as relevant to GIE releases.Categorizes an issue or PR as relevant to GIE releases.good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.triage/acceptedIndicates an issue or PR is ready to be actively worked on.Indicates an issue or PR is ready to be actively worked on.