Skip to content

🐛 (helm/v2alpha): allow manager values to be customized properly #5147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2025
+825 −139
Merged

🐛 (helm/v2alpha): allow manager values to be customized properly #5147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 24 additions & 15 deletions docs/book/src/cronjob-tutorial/testdata/project/dist/chart/templates/manager/manager.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,16 @@ spec:
spec:
containers:
- args:
{{- if .Values.metrics.enable }}
- --metrics-bind-address=:8443
- --leader-elect
{{- else }}
# Bind to :0 to disable the controller-runtime managed metrics server
- --metrics-bind-address=0
{{- end }}
- --health-probe-bind-address=:8081
{{- range .Values.controllerManager.args }}
- {{ . }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that we have the possible args exposed now

{{- end }}
{{- if and .Values.certManager.enable .Values.metrics.enable }}
- --metrics-cert-path=/tmp/k8s-metrics-server/metrics-certs
{{- end }}
Expand All @@ -35,6 +42,7 @@ spec:
command:
- /manager
image: "{{ .Values.controllerManager.image.repository }}:{{ .Values.controllerManager.image.tag }}"
imagePullPolicy: {{ .Values.controllerManager.image.pullPolicy }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting from the helm values it was missing

livenessProbe:
httpGet:
path: /healthz
Expand All @@ -53,18 +61,17 @@ spec:
initialDelaySeconds: 5
periodSeconds: 10
resources:
limits:
cpu: 500m
memory: 128Mi
requests:
cpu: 10m
memory: 64Mi
{{- if .Values.controllerManager.resources }}
{{- toYaml .Values.controllerManager.resources | nindent 20 }}
{{- else }}
{}
{{- end }}
securityContext:
allowPrivilegeEscalation: false
capabilities:
drop:
- ALL
readOnlyRootFilesystem: true
{{- if .Values.controllerManager.securityContext }}
{{- toYaml .Values.controllerManager.securityContext | nindent 20 }}
{{- else }}
{}
{{- end }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting from helm values it was missing

volumeMounts:
{{- if and .Values.certManager.enable .Values.metrics.enable }}
- mountPath: /tmp/k8s-metrics-server/metrics-certs
Expand All @@ -77,9 +84,11 @@ spec:
readOnly: true
{{- end }}
securityContext:
runAsNonRoot: true
seccompProfile:
type: RuntimeDefault
{{- if .Values.controllerManager.podSecurityContext }}
{{- toYaml .Values.controllerManager.podSecurityContext | nindent 14 }}
{{- else }}
{}
{{- end }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting from helm values it was missing

serviceAccountName: project-controller-manager
terminationGracePeriodSeconds: 10
volumes:
Expand Down
4 changes: 4 additions & 0 deletions docs/book/src/cronjob-tutorial/testdata/project/dist/chart/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ controllerManager:
tag: latest
pullPolicy: IfNotPresent

# Arguments
args:
- --leader-elect

# Environment variables
env: []

Expand Down
39 changes: 24 additions & 15 deletions docs/book/src/getting-started/testdata/project/dist/chart/templates/manager/manager.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,20 @@ spec:
spec:
containers:
- args:
{{- if .Values.metrics.enable }}
- --metrics-bind-address=:8443
- --leader-elect
{{- else }}
# Bind to :0 to disable the controller-runtime managed metrics server
- --metrics-bind-address=0
{{- end }}
- --health-probe-bind-address=:8081
{{- range .Values.controllerManager.args }}
- {{ . }}
{{- end }}
command:
- /manager
image: "{{ .Values.controllerManager.image.repository }}:{{ .Values.controllerManager.image.tag }}"
imagePullPolicy: {{ .Values.controllerManager.image.pullPolicy }}
livenessProbe:
httpGet:
path: /healthz
Expand All @@ -44,23 +52,24 @@ spec:
initialDelaySeconds: 5
periodSeconds: 10
resources:
limits:
cpu: 500m
memory: 128Mi
requests:
cpu: 10m
memory: 64Mi
{{- if .Values.controllerManager.resources }}
{{- toYaml .Values.controllerManager.resources | nindent 20 }}
{{- else }}
{}
{{- end }}
securityContext:
allowPrivilegeEscalation: false
capabilities:
drop:
- ALL
readOnlyRootFilesystem: true
{{- if .Values.controllerManager.securityContext }}
{{- toYaml .Values.controllerManager.securityContext | nindent 20 }}
{{- else }}
{}
{{- end }}
volumeMounts: []
securityContext:
runAsNonRoot: true
seccompProfile:
type: RuntimeDefault
{{- if .Values.controllerManager.podSecurityContext }}
{{- toYaml .Values.controllerManager.podSecurityContext | nindent 14 }}
{{- else }}
{}
{{- end }}
serviceAccountName: project-controller-manager
terminationGracePeriodSeconds: 10
volumes: []
4 changes: 4 additions & 0 deletions docs/book/src/getting-started/testdata/project/dist/chart/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ controllerManager:
tag: latest
pullPolicy: IfNotPresent

# Arguments
args:
- --leader-elect

# Environment variables
env: []

Expand Down
39 changes: 24 additions & 15 deletions ...book/src/multiversion-tutorial/testdata/project/dist/chart/templates/manager/manager.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,16 @@ spec:
spec:
containers:
- args:
{{- if .Values.metrics.enable }}
- --metrics-bind-address=:8443
- --leader-elect
{{- else }}
# Bind to :0 to disable the controller-runtime managed metrics server
- --metrics-bind-address=0
{{- end }}
- --health-probe-bind-address=:8081
{{- range .Values.controllerManager.args }}
- {{ . }}
{{- end }}
{{- if and .Values.certManager.enable .Values.metrics.enable }}
- --metrics-cert-path=/tmp/k8s-metrics-server/metrics-certs
{{- end }}
Expand All @@ -35,6 +42,7 @@ spec:
command:
- /manager
image: "{{ .Values.controllerManager.image.repository }}:{{ .Values.controllerManager.image.tag }}"
imagePullPolicy: {{ .Values.controllerManager.image.pullPolicy }}
livenessProbe:
httpGet:
path: /healthz
Expand All @@ -53,18 +61,17 @@ spec:
initialDelaySeconds: 5
periodSeconds: 10
resources:
limits:
cpu: 500m
memory: 128Mi
requests:
cpu: 10m
memory: 64Mi
{{- if .Values.controllerManager.resources }}
{{- toYaml .Values.controllerManager.resources | nindent 20 }}
{{- else }}
{}
{{- end }}
securityContext:
allowPrivilegeEscalation: false
capabilities:
drop:
- ALL
readOnlyRootFilesystem: true
{{- if .Values.controllerManager.securityContext }}
{{- toYaml .Values.controllerManager.securityContext | nindent 20 }}
{{- else }}
{}
{{- end }}
volumeMounts:
{{- if and .Values.certManager.enable .Values.metrics.enable }}
- mountPath: /tmp/k8s-metrics-server/metrics-certs
Expand All @@ -77,9 +84,11 @@ spec:
readOnly: true
{{- end }}
securityContext:
runAsNonRoot: true
seccompProfile:
type: RuntimeDefault
{{- if .Values.controllerManager.podSecurityContext }}
{{- toYaml .Values.controllerManager.podSecurityContext | nindent 14 }}
{{- else }}
{}
{{- end }}
serviceAccountName: project-controller-manager
terminationGracePeriodSeconds: 10
volumes:
Expand Down
4 changes: 4 additions & 0 deletions docs/book/src/multiversion-tutorial/testdata/project/dist/chart/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ controllerManager:
tag: latest
pullPolicy: IfNotPresent

# Arguments
args:
- --leader-elect

# Environment variables
env: []

Expand Down
Loading
Loading