Skip to content

Commit cd74adf

Browse files
committed
tide: changes requested block merge
1 parent 8026e80 commit cd74adf

File tree

2 files changed

+515
-1
lines changed

2 files changed

+515
-1
lines changed

pkg/tide/status.go

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,13 @@ func requirementDiff(pr *PullRequest, q *config.TideQuery, cc contextChecker) (s
254254
}
255255
}
256256

257-
if q.ReviewApprovedRequired && pr.ReviewDecision != githubql.PullRequestReviewDecisionApproved {
257+
// PullRequestReviewDecisionChangesRequested is similar to not approved
258+
if pr.ReviewDecision == githubql.PullRequestReviewDecisionChangesRequested {
259+
diff += 50
260+
if desc == "" {
261+
desc = " PR has changes requested in reviews"
262+
}
263+
} else if q.ReviewApprovedRequired && pr.ReviewDecision != githubql.PullRequestReviewDecisionApproved {
258264
diff += 50
259265
if desc == "" {
260266
desc = " PullRequest is missing sufficient approving GitHub review(s)"

0 commit comments

Comments
 (0)