ci: dedicated UT jobs for CA and VPA #8669

jackfrancis · 2025-10-20T21:51:06Z

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR creates new cluster-autoscaler-test and vertical-pod-autoscaler-test GitHub action jobs, and renames verify-and-test to `verify.

This will ensure we run only the tests we need for the changes in a particular PR, and should help prevent full disk errors from running a bunch of test and verify runs in a single job.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot · 2025-10-20T21:51:16Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jackfrancis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

adrianmoisey · 2025-10-21T04:11:44Z

.github/workflows/ca-test.yaml

@@ -0,0 +1,41 @@
+name: Cluster Autoscaler Tests


A bit of a nit, could this be Cluster Autoscaler (and then VPA be Vertical Pod Autoscaler)

Then line 19 of this file gets changed to test (and similar in the VPA file).
Then make similar changes to the new vpa-golangci-lint.yaml file I made.

The reason is then this summary:

Will be:

Cluster Autoscaler / Test
Vertical Pod Autoscaler / Test
Vertical Pod Autoscaler / Lint

Making it super clear what is running

Then in the future when we break up verify too, we will have:

Cluster Autoscaler / Test
Cluster Autoscaler / Verify
Vertical Pod Autoscaler / Test
Vertical Pod Autoscaler / Verify
Vertical Pod Autoscaler / Lint

If we rename these "Cluster Autoscaler" and "Vertical Pod Autoscaler", then we are setting ourselves up to create monolith GitHub action definitions again (which we are trying to get away from). Are we confident that a single job for CA and VPA won't fill up storage like we recently encountered?

If we rename these "Cluster Autoscaler" and "Vertical Pod Autoscaler", then we are setting ourselves up to create monolith GitHub action definitions again (which we are trying to get away from).

It's possible to have multiple GitHub actions with the same name, each one containing only a single job

towca · 2025-10-21T17:15:45Z

hack/for-go-proj.sh

-  "build")
+PROJECT="${1}"
+
+case "${PROJECT}" in


Given that the logic is slightly different for each project anyway, I wonder if we should go a step further and just have a per-project file instead of keeping a single entry point here? If not, could we at least rename this file to something more accurate (e.g. run-unit-tests.sh)?

I'm fine with per-project files
These projects aren't really related at all, and only just share a repo.
Having to maintain the logic of handling multiple projects is sometimes annoying

Agree on that

I'll do this in a follow-up PR so the changes can be more discrete to eval and potentially roll back

towca · 2025-10-21T17:17:06Z

hack/for-go-proj.sh

-  "install")
+  "vertical-pod-autoscaler")
+    pushd ${CONTRIB_ROOT}/vertical-pod-autoscaler
+    go test -count=1  -race $(go list ./... | grep -v /vendor/ | grep -v vertical-pod-autoscaler/e2e | grep -v cluster-autoscaler/apis)


Hm, the cluster-autoscaler/apis shouldn't be relevant anymore, it only applied to CA. Same with vertical-pod-autoscaler/e2e and addon-resizer below.

I'll take this feedback and the feedback for per-project shell scripts as a follow-up.

towca · 2025-10-21T17:19:12Z

I have 2 comments but they're more nits, don't block on them if needed. Adding a hold for other reviewers.

/lgtm
/hold

adrianmoisey · 2025-10-31T06:58:13Z

Bump

jackfrancis · 2025-10-31T15:56:13Z

/label tide/merge-method-squash

jackfrancis · 2025-10-31T15:57:08Z

@adrianmoisey @towca this should be ready for a final review? I'll split out CA/VPA from the common shell scripts as follow-up tasks

adrianmoisey · 2025-10-31T18:52:29Z

/lgtm

Thanks!

jackfrancis · 2025-10-31T18:53:47Z

/hold cancel

jackfrancis · 2025-10-31T22:28:36Z

/cherry-pick cluster-autoscaler-release-1.34

k8s-infra-cherrypick-robot · 2025-10-31T22:29:13Z

@jackfrancis: #8669 failed to apply on top of branch "cluster-autoscaler-release-1.34":

Applying: ci: dedicated UT jobs for CA and VPA
Using index info to reconstruct a base tree...
M	.github/workflows/ci.yaml
Falling back to patching base and 3-way merge...
Auto-merging .github/workflows/verify.yaml
CONFLICT (content): Merge conflict in .github/workflows/verify.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 ci: dedicated UT jobs for CA and VPA

In response to this:

/cherry-pick cluster-autoscaler-release-1.34

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area labels Oct 20, 2025

k8s-ci-robot requested review from kgolab and towca October 20, 2025 21:51

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 20, 2025

jackfrancis force-pushed the ci-split-test-verify branch from 8b43c4a to d160e93 Compare October 20, 2025 21:51

k8s-ci-robot added area/cluster-autoscaler area/vertical-pod-autoscaler and removed do-not-merge/needs-area labels Oct 20, 2025

adrianmoisey reviewed Oct 21, 2025

View reviewed changes

towca reviewed Oct 21, 2025

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2025

k8s-ci-robot assigned towca Oct 21, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2025

jackfrancis added 4 commits October 31, 2025 08:47

ci: dedicated UT jobs for CA and VPA

e7253ae

changes to ca and vpa to trigger tests

bbb1906

missing ;;

ea18cc8

rename test configs to Cluster Autoscaler and Vertical Pod Autoscaler

adcd6bc

jackfrancis force-pushed the ci-split-test-verify branch from c751abf to adcd6bc Compare October 31, 2025 15:52

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2025

k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 31, 2025

jackfrancis mentioned this pull request Oct 31, 2025

azure: enable testing with LTS on AKS #8722

Merged

k8s-ci-robot assigned adrianmoisey Oct 31, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2025

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2025

k8s-ci-robot merged commit b6e1991 into kubernetes:master Oct 31, 2025
15 checks passed

jackfrancis deleted the ci-split-test-verify branch October 31, 2025 19:44

adrianmoisey mentioned this pull request Nov 1, 2025

Remove test-and-verify kubernetes/test-infra#35833

Open

ci: dedicated UT jobs for CA and VPA #8669

ci: dedicated UT jobs for CA and VPA #8669

Conversation

jackfrancis commented Oct 20, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Uh oh!

k8s-ci-robot commented Oct 20, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

towca Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

towca commented Oct 21, 2025

Uh oh!

adrianmoisey commented Oct 31, 2025

Uh oh!

jackfrancis commented Oct 31, 2025

Uh oh!

jackfrancis commented Oct 31, 2025

Uh oh!

adrianmoisey commented Oct 31, 2025

Uh oh!

jackfrancis commented Oct 31, 2025

Uh oh!

Uh oh!

jackfrancis commented Oct 31, 2025

Uh oh!

k8s-infra-cherrypick-robot commented Oct 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

towca Oct 21, 2025 •

edited

Loading