Skip to content

feat(vpa-chart): support updater rbac #8699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Nov 7, 2025
Merged

feat(vpa-chart): support updater rbac #8699

k8s-ci-robot merged 1 commit into from
Nov 7, 2025

Conversation

@kincoy
Copy link
Contributor

@kincoy kincoy commented Oct 28, 2025

What type of PR is this?

Part of: #8587

For vpa-updater:

  • ServiceAccount
  • RBAC (ClusterRole, RoleBinding)

/kind feature

Special notes for your reviewer:

I following the existing manifests in veritcal-pod-autoscaler/deploy/rbac.yaml about updater

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area labels Oct 28, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 28, 2025

Hi @kincoy. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/vertical-pod-autoscaler size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-area labels Oct 28, 2025
@kincoy
Copy link
Contributor Author

kincoy commented Oct 28, 2025

I tested it using the default setup:
helm upgrade --install vpa ./vertical-pod-autoscaler/charts/vertical-pod-autoscaler/ -n vpa --create-namespace
and template:
helm template vertical-pod-autoscaler ./vertical-pod-autoscaler --output-dir rendered

@kincoy kincoy force-pushed the vpa-chart-updater-rbac branch from 23e351c to 48e91e7 Compare October 28, 2025 06:21
@kincoy kincoy force-pushed the vpa-chart-updater-rbac branch from 48e91e7 to 0d26254 Compare October 29, 2025 02:40
omerap12
omerap12 reviewed Oct 29, 2025
View reviewed changes
Copy link
Member

@omerap12 omerap12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!
/lgtm
/assign @adrianmoisey

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 29, 2025
@kincoy kincoy force-pushed the vpa-chart-updater-rbac branch from 0d26254 to 59aa6b5 Compare October 31, 2025 02:37
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 31, 2025
@kincoy
Copy link
Contributor Author

kincoy commented Oct 31, 2025

@omerap12 Hi , I fixed the merge conflict, which removed the previous LGTM.
Please review again when you have time. Thanks! cc @adrianmoisey

@adrianmoisey
Copy link
Member

adrianmoisey commented Oct 31, 2025

Thank you!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2025
omerap12
omerap12 approved these changes Oct 31, 2025
View reviewed changes
Copy link
Member

@omerap12 omerap12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/release-note none
/ok-to-test
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 31, 2025
@omerap12
Copy link
Member

omerap12 commented Oct 31, 2025

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 31, 2025
@adrianmoisey
Copy link
Member

adrianmoisey commented Oct 31, 2025

@kincoy sorry for this, but we just changed up the e2e tests for the VPA. The failing test is new, and requires master merged into your branch

@kincoy
feat(vpa-chart): support updater rbac
ba36cab 
Signed-off-by: kincoy <kincoyao@gmail.com>
@kincoy kincoy force-pushed the vpa-chart-updater-rbac branch from 59aa6b5 to ba36cab Compare November 1, 2025 13:50
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2025
@kincoy
Copy link
Contributor Author

kincoy commented Nov 1, 2025

@adrianmoisey got it, i've fixed it. please approve again, thank you!

omerap12
omerap12 approved these changes Nov 7, 2025
View reviewed changes
Copy link
Member

@omerap12 omerap12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since @adrianmoisey already approved, we can merge this. thanks!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kincoy, omerap12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d5d6bf3 into kubernetes:master Nov 7, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adrianmoisey adrianmoisey adrianmoisey left review comments

+1 more reviewer

@omerap12 omerap12 omerap12 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@adrianmoisey adrianmoisey

@omerap12 omerap12

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kincoy @k8s-ci-robot @adrianmoisey @omerap12