Skip to content

Commit db0867e

Browse files
committed
rewrite retest robot comment
1. The Kubernetes project should not have merge-blocking tests that are too flaky to consistently pass, we've worked hard to eliminate these, and if they come up again it should not be treated as normal 2. The text here is way too long, we should focus on the most essentail details. The contributor does not need to know the search query and we're not even including all of it. 3. Prioritize encouraging helping fix test flakes early in the message instead of ~at the end. 4. The full test history link is already included in test failure comments.
1 parent e4b4ee5 commit db0867e

File tree

1 file changed

+2
-12
lines changed

1 file changed

+2
-12
lines changed

config/jobs/kubernetes/sig-k8s-infra/trusted/sig-contribex-k8s-triage-robot.yaml

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -290,19 +290,9 @@ periodics:
290290
- --token=/etc/github-token/token
291291
- --endpoint=http://ghproxy.test-pods.svc.cluster.local
292292
- |-
293-
--comment=The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.
293+
--comment=Retesting failed PR that otherwise appears ready for merge.
294294
295-
This bot retests PRs for certain kubernetes repos according to the following rules:
296-
- The PR does have any `do-not-merge/*` labels
297-
- The PR does not have the `needs-ok-to-test` label
298-
- The PR is mergeable (does not have a `needs-rebase` label)
299-
- The PR is approved (has `cncf-cla: yes`, `lgtm`, `approved` labels)
300-
- The PR is failing tests required for merge
301-
302-
You can:
303-
- Review the [full test history](https://prow.k8s.io/pr-history/?org={{.Org}}&repo={{.Repo}}&pr={{.Number}}) for this PR
304-
- Prevent this bot from retesting with `/lgtm cancel` or `/hold`
305-
- Help make our tests less flaky by following our [Flaky Tests Guide][1]
295+
Please help us fix flaky tests by following our [Flaky Tests Guide][1]
306296
307297
/retest-required
308298

0 commit comments

Comments
 (0)